|
As per the discussion in [1], I implemented the enhanced breadcrumb.
The code is currently in a branch [2]. The screenshot is attached. Breadcrumb is now sticky --- when you scroll down, it sticks to the top of the page and never goes out of the viewport. Hovering the mouse over it will show the menu, and when you move your mouse out of the menu, it'll disappear automatically. The breadcrumb itself is still clickable as it has been. As you see in the screenshot, the breadcrumb now occupies more space (or easiler access to the context menu), and it's bordered. I'm not a UX guy, and I'm not too crazy about borders here (it appears somewhat out of style with the rest of Jenkins UI, although foldable sidepanel might change that.) With that said, I ended up adding it to create a boundary for sticky breadcrumb. Internally, it ses sidepanel.groovy/jelly to generate the menu contents by default, which lets us instantly activate this feature for all those objects that people have been writing. But model classes can override this behavior and completely take over the menu generation if so choose. Future enhancements include submenus. Does this sound like what we want? Feedbacks from graphics/UX guys (and I'm looking at Manfred!) would be especially appreciated. [1] https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+notes [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb -- Kohsuke Kawaguchi |
|
+1 +1 +1
On 21 February 2012 14:15, Kohsuke Kawaguchi <[hidden email]> wrote: As per the discussion in [1], I implemented the enhanced breadcrumb. |
|
In reply to this post by kohsuke Kawaguchi (CB)
Another UI idea:
Say I wanted to queue a build for all jobs in a view at once. Could we add a build all jobs in view button? Maybe at the bottom of the view dashboard page. What to people think? On 21 February 2012 14:15, Kohsuke Kawaguchi <[hidden email]> wrote: As per the discussion in [1], I implemented the enhanced breadcrumb. |
|
+1
Emanuele Zattin --------------------------------------------------- -I don't have to know an answer. I don't feel frightened by not knowing things; by being lost in a mysterious universe without any purpose — which is the way it really is, as far as I can tell, possibly. It doesn't frighten me.- Richard Feynman On Tue, Feb 21, 2012 at 5:43 AM, Andrew Gray <[hidden email]> wrote: > Another UI idea: > > Say I wanted to queue a build for all jobs in a view at once. > > Could we add a build all jobs in view button? Maybe at the bottom of the > view dashboard page. > > What to people think? > > > > > On 21 February 2012 14:15, Kohsuke Kawaguchi <[hidden email]> > wrote: >> >> As per the discussion in [1], I implemented the enhanced breadcrumb. >> The code is currently in a branch [2]. The screenshot is attached. >> >> Breadcrumb is now sticky --- when you scroll down, it sticks to the >> top of the page and never goes out of the viewport. Hovering the mouse >> over it will show the menu, and when you move your mouse out of the >> menu, it'll disappear automatically. The breadcrumb itself is still >> clickable as it has been. >> >> As you see in the screenshot, the breadcrumb now occupies more space >> (or easiler access to the context menu), and it's bordered. >> >> I'm not a UX guy, and I'm not too crazy about borders here (it appears >> somewhat out of style with the rest of Jenkins UI, although foldable >> sidepanel might change that.) With that said, I ended up adding it to >> create a boundary for sticky breadcrumb. >> >> Internally, it ses sidepanel.groovy/jelly to generate the menu >> contents by default, which lets us instantly activate this feature for >> all those objects that people have been writing. But model classes can >> override this behavior and completely take over the menu generation if >> so choose. >> >> Future enhancements include submenus. >> >> Does this sound like what we want? Feedbacks from graphics/UX guys >> (and I'm looking at Manfred!) would be especially appreciated. >> >> [1] >> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+notes >> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb >> -- >> Kohsuke Kawaguchi > > |
|
In reply to this post by Andrew Gray
Greetings,
On Mon, Feb 20, 2012 at 11:43 PM, Andrew Gray <[hidden email]> wrote: > Say I wanted to queue a build for all jobs in a view at once. I don't disagree that it could be more conveniently or prominently displayed, but https://wiki.jenkins-ci.org/display/JENKINS/Bulk+Builder+Plugin does have a way to bulk submit all jobs in a View. -Jesse -- There are 10 types of people in this world, those that can read binary and those that can not. |
|
Hi All,
While we are speaking about Ui "fixes", one thing I never understood is why we have not changed Jenkins to match the new red and black color scheme. There is a pull request somewhere with the work all done it just needs to be merged.
I really think it would add to the brand not only in its own right but also to distinguish Jenkins from Hudson. While "Branding" IS marketing and marketing is something that we developers may hold is less regard than enhanced functionality, marketing has its place.
From someone who wants to see the widest possible adoption of Jenkins, it is business-type people that I often need to convince not only on the idea of CI but also that Jenkins is the correct choice therefore a completely aligned brand has value.
We all want Jenkins to look as professional a package as possible, therefore on this basis I ask that the pull request be merged as part of this Ui improvement drive.
Happy to discuss, over to you. Regards, Andrew On Wednesday, February 22, 2012, Jesse Farinacci wrote: Greetings, |
|
wow - its not me starting this again :) here it is.../Domi On 22.02.2012, at 10:54, Andrew Gray wrote: Hi All, |
|
In reply to this post by kohsuke Kawaguchi (CB)
I personally dont like any kind of menu/overlay/popups. The plain old
html page is just perfect. Tooltip might be the only thing that floats over a html page. But again, thats only my personal opinion. On 21.02.2012 04:15, Kohsuke Kawaguchi wrote: > As per the discussion in [1], I implemented the enhanced breadcrumb. > The code is currently in a branch [2]. The screenshot is attached. > > Breadcrumb is now sticky --- when you scroll down, it sticks to the > top of the page and never goes out of the viewport. Hovering the mouse > over it will show the menu, and when you move your mouse out of the > menu, it'll disappear automatically. The breadcrumb itself is still > clickable as it has been. > > As you see in the screenshot, the breadcrumb now occupies more space > (or easiler access to the context menu), and it's bordered. > > I'm not a UX guy, and I'm not too crazy about borders here (it appears > somewhat out of style with the rest of Jenkins UI, although foldable > sidepanel might change that.) With that said, I ended up adding it to > create a boundary for sticky breadcrumb. > > Internally, it ses sidepanel.groovy/jelly to generate the menu > contents by default, which lets us instantly activate this feature for > all those objects that people have been writing. But model classes can > override this behavior and completely take over the menu generation if > so choose. > > Future enhancements include submenus. > > Does this sound like what we want? Feedbacks from graphics/UX guys > (and I'm looking at Manfred!) would be especially appreciated. > > [1] https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+notes > [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb > |
|
In reply to this post by kohsuke Kawaguchi (CB)
It would be great if the menu could be activated from any link to a model
object, not just from the breadcrumb bar. For example, there have been many times I wished I could quickly jump to the configuration or console of a job from the upstream/downstream jobs section of a page. We could get rid of a lot of custom dashboard view columns if the menu could be activated from the links in the views. This would mean refactoring all model object links in Jelly files to use a modellink.jelly template, but it would be a consistent experience. -- Dean On 2/20/12 7:15 PM , "Kohsuke Kawaguchi" <[hidden email]> wrote: > As per the discussion in [1], I implemented the enhanced breadcrumb. > The code is currently in a branch [2]. The screenshot is attached. > > Breadcrumb is now sticky --- when you scroll down, it sticks to the > top of the page and never goes out of the viewport. Hovering the mouse > over it will show the menu, and when you move your mouse out of the > menu, it'll disappear automatically. The breadcrumb itself is still > clickable as it has been. > > As you see in the screenshot, the breadcrumb now occupies more space > (or easiler access to the context menu), and it's bordered. > > I'm not a UX guy, and I'm not too crazy about borders here (it appears > somewhat out of style with the rest of Jenkins UI, although foldable > sidepanel might change that.) With that said, I ended up adding it to > create a boundary for sticky breadcrumb. > > Internally, it ses sidepanel.groovy/jelly to generate the menu > contents by default, which lets us instantly activate this feature for > all those objects that people have been writing. But model classes can > override this behavior and completely take over the menu generation if > so choose. > > Future enhancements include submenus. > > Does this sound like what we want? Feedbacks from graphics/UX guys > (and I'm looking at Manfred!) would be especially appreciated. > > [1] > https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+n > otes > [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb |
|
Administrator
|
In reply to this post by Jesse Farinacci
Yes, this seems like something better left in a plugin, and as Jesse
says, it already exists. 2012/2/22 Jesse Farinacci <[hidden email]>: > Greetings, > > On Mon, Feb 20, 2012 at 11:43 PM, Andrew Gray > <[hidden email]> wrote: >> Say I wanted to queue a build for all jobs in a view at once. > > I don't disagree that it could be more conveniently or prominently > displayed, but https://wiki.jenkins-ci.org/display/JENKINS/Bulk+Builder+Plugin > does have a way to bulk submit all jobs in a View. > > -Jesse > > -- > There are 10 types of people in this world, those > that can read binary and those that can not. -- Kohsuke Kawaguchi |
|
In reply to this post by Dean Yu
Hmm, that's interesting. It is relatively easy to build this on top of
what we have. Definitely worth experimenting. Any thoughts on this from others? 2012/2/24 Dean Yu <[hidden email]>: > It would be great if the menu could be activated from any link to a model > object, not just from the breadcrumb bar. For example, there have been many > times I wished I could quickly jump to the configuration or console of a job > from the upstream/downstream jobs section of a page. We could get rid of a > lot of custom dashboard view columns if the menu could be activated from the > links in the views. > > This would mean refactoring all model object links in Jelly files to use a > modellink.jelly template, but it would be a consistent experience. > > -- Dean > > > On 2/20/12 7:15 PM , "Kohsuke Kawaguchi" <[hidden email]> wrote: > >> As per the discussion in [1], I implemented the enhanced breadcrumb. >> The code is currently in a branch [2]. The screenshot is attached. >> >> Breadcrumb is now sticky --- when you scroll down, it sticks to the >> top of the page and never goes out of the viewport. Hovering the mouse >> over it will show the menu, and when you move your mouse out of the >> menu, it'll disappear automatically. The breadcrumb itself is still >> clickable as it has been. >> >> As you see in the screenshot, the breadcrumb now occupies more space >> (or easiler access to the context menu), and it's bordered. >> >> I'm not a UX guy, and I'm not too crazy about borders here (it appears >> somewhat out of style with the rest of Jenkins UI, although foldable >> sidepanel might change that.) With that said, I ended up adding it to >> create a boundary for sticky breadcrumb. >> >> Internally, it ses sidepanel.groovy/jelly to generate the menu >> contents by default, which lets us instantly activate this feature for >> all those objects that people have been writing. But model classes can >> override this behavior and completely take over the menu generation if >> so choose. >> >> Future enhancements include submenus. >> >> Does this sound like what we want? Feedbacks from graphics/UX guys >> (and I'm looking at Manfred!) would be especially appreciated. >> >> [1] >> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+n >> otes >> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb > -- Kohsuke Kawaguchi |
|
Administrator
|
In reply to this post by Andrew Gray
I'm neither a graphics guy nor a marketing guy, so I'd be happy to be
overriden, but I thought the argument from the other side is the continuity from our previous name. In FOSDEM and in SCALE 10x, I had several occasions where people who didn't know about Jenkins came over and I was able to quickly convince them that we are the natural continuation thanks to the similarity of the UI. The other thing is that the current color scheme is from Tango color palette, where we draw icons from. So presumably colors look more consistent with icons, etc. 2012/2/22 Andrew Gray <[hidden email]>: > Hi All, > > While we are speaking about Ui "fixes", one thing I never understood is why > we have not changed Jenkins to match the new red and black color scheme. > There is a pull request somewhere with the work all done it just needs to > be merged. > > I really think it would add to the brand not only in its own right but also > to distinguish Jenkins from Hudson. > > While "Branding" IS marketing and marketing is something that we developers > may hold is less regard than enhanced functionality, marketing has its > place. > > From someone who wants to see the widest possible adoption of Jenkins, it is > business-type people that I often need to convince not only on the idea of > CI but also that Jenkins is the correct choice therefore a completely > aligned brand has value. > > We all want Jenkins to look as professional a package as possible, therefore > on this basis I ask that the pull request be merged as part of this Ui > improvement drive. > > Happy to discuss, over to you. > > Regards, > > Andrew > > > On Wednesday, February 22, 2012, Jesse Farinacci wrote: >> >> Greetings, >> >> On Mon, Feb 20, 2012 at 11:43 PM, Andrew Gray >> <[hidden email]> wrote: >> > Say I wanted to queue a build for all jobs in a view at once. >> >> I don't disagree that it could be more conveniently or prominently >> displayed, but >> https://wiki.jenkins-ci.org/display/JENKINS/Bulk+Builder+Plugin >> does have a way to bulk submit all jobs in a View. >> >> -Jesse >> >> -- >> There are 10 types of people in this world, those >> that can read binary and those that can not. -- Kohsuke Kawaguchi |
|
In reply to this post by kohsuke Kawaguchi (CB)
I also think that having this option on every model object would be a really good idea.
e.g. this could be useful in the executor list too /Domi On 24.02.2012, at 00:26, Kohsuke Kawaguchi wrote: > Hmm, that's interesting. It is relatively easy to build this on top of > what we have. > > Definitely worth experimenting. Any thoughts on this from others? > > 2012/2/24 Dean Yu <[hidden email]>: >> It would be great if the menu could be activated from any link to a model >> object, not just from the breadcrumb bar. For example, there have been many >> times I wished I could quickly jump to the configuration or console of a job >> from the upstream/downstream jobs section of a page. We could get rid of a >> lot of custom dashboard view columns if the menu could be activated from the >> links in the views. >> >> This would mean refactoring all model object links in Jelly files to use a >> modellink.jelly template, but it would be a consistent experience. >> >> -- Dean >> >> >> On 2/20/12 7:15 PM , "Kohsuke Kawaguchi" <[hidden email]> wrote: >> >>> As per the discussion in [1], I implemented the enhanced breadcrumb. >>> The code is currently in a branch [2]. The screenshot is attached. >>> >>> Breadcrumb is now sticky --- when you scroll down, it sticks to the >>> top of the page and never goes out of the viewport. Hovering the mouse >>> over it will show the menu, and when you move your mouse out of the >>> menu, it'll disappear automatically. The breadcrumb itself is still >>> clickable as it has been. >>> >>> As you see in the screenshot, the breadcrumb now occupies more space >>> (or easiler access to the context menu), and it's bordered. >>> >>> I'm not a UX guy, and I'm not too crazy about borders here (it appears >>> somewhat out of style with the rest of Jenkins UI, although foldable >>> sidepanel might change that.) With that said, I ended up adding it to >>> create a boundary for sticky breadcrumb. >>> >>> Internally, it ses sidepanel.groovy/jelly to generate the menu >>> contents by default, which lets us instantly activate this feature for >>> all those objects that people have been writing. But model classes can >>> override this behavior and completely take over the menu generation if >>> so choose. >>> >>> Future enhancements include submenus. >>> >>> Does this sound like what we want? Feedbacks from graphics/UX guys >>> (and I'm looking at Manfred!) would be especially appreciated. >>> >>> [1] >>> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+n >>> otes >>> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb >> > > > > -- > Kohsuke Kawaguchi |
|
My only concern would be to test this with bigger installations as well. When having 1000 jobs in one instance innocent looking 200 bytes of information per job may make a big difference :-D. Regards Mirko On Feb 24, 2012 7:40 PM, "domi" <[hidden email]> wrote:
I also think that having this option on every model object would be a really good idea. |
|
Administrator
|
The implementation is done in such a way that there's no extra data
loaded until you actually activate the menu (by hovering the mouse over), so I think we are OK with this regard. 2012/2/24 Mirko Friedenhagen <[hidden email]>: > My only concern would be to test this with bigger installations as well. > When having 1000 jobs in one instance innocent looking 200 bytes of > information per job may make a big difference :-D. > > Regards Mirko > -- > Sent from my phone > http://illegalstateexception.blogspot.com > http://github.com/mfriedenhagen/ > https://bitbucket.org/mfriedenhagen/ > > On Feb 24, 2012 7:40 PM, "domi" <[hidden email]> wrote: >> >> I also think that having this option on every model object would be a >> really good idea. >> e.g. this could be useful in the executor list too >> /Domi >> >> >> On 24.02.2012, at 00:26, Kohsuke Kawaguchi wrote: >> >> > Hmm, that's interesting. It is relatively easy to build this on top of >> > what we have. >> > >> > Definitely worth experimenting. Any thoughts on this from others? >> > >> > 2012/2/24 Dean Yu <[hidden email]>: >> >> It would be great if the menu could be activated from any link to a >> >> model >> >> object, not just from the breadcrumb bar. For example, there have been >> >> many >> >> times I wished I could quickly jump to the configuration or console of >> >> a job >> >> from the upstream/downstream jobs section of a page. We could get rid >> >> of a >> >> lot of custom dashboard view columns if the menu could be activated >> >> from the >> >> links in the views. >> >> >> >> This would mean refactoring all model object links in Jelly files to >> >> use a >> >> modellink.jelly template, but it would be a consistent experience. >> >> >> >> -- Dean >> >> >> >> >> >> On 2/20/12 7:15 PM , "Kohsuke Kawaguchi" <[hidden email]> >> >> wrote: >> >> >> >>> As per the discussion in [1], I implemented the enhanced breadcrumb. >> >>> The code is currently in a branch [2]. The screenshot is attached. >> >>> >> >>> Breadcrumb is now sticky --- when you scroll down, it sticks to the >> >>> top of the page and never goes out of the viewport. Hovering the mouse >> >>> over it will show the menu, and when you move your mouse out of the >> >>> menu, it'll disappear automatically. The breadcrumb itself is still >> >>> clickable as it has been. >> >>> >> >>> As you see in the screenshot, the breadcrumb now occupies more space >> >>> (or easiler access to the context menu), and it's bordered. >> >>> >> >>> I'm not a UX guy, and I'm not too crazy about borders here (it appears >> >>> somewhat out of style with the rest of Jenkins UI, although foldable >> >>> sidepanel might change that.) With that said, I ended up adding it to >> >>> create a boundary for sticky breadcrumb. >> >>> >> >>> Internally, it ses sidepanel.groovy/jelly to generate the menu >> >>> contents by default, which lets us instantly activate this feature for >> >>> all those objects that people have been writing. But model classes can >> >>> override this behavior and completely take over the menu generation if >> >>> so choose. >> >>> >> >>> Future enhancements include submenus. >> >>> >> >>> Does this sound like what we want? Feedbacks from graphics/UX guys >> >>> (and I'm looking at Manfred!) would be especially appreciated. >> >>> >> >>> [1] >> >>> >> >>> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+n >> >>> otes >> >>> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb >> >> >> > >> > >> > >> > -- >> > Kohsuke Kawaguchi >> > -- Kohsuke Kawaguchi |
|
I've pushed this in https://github.com/jenkinsci/jenkins/tree/breadcrumb Most of the list view links now support navigation menus (it's just a matter of adding class='model-link' to the <a> tag), so you can get the sense of how this behaves. You need to hover the mouse on <a> tags and wait for a bit before the menu shows up. I added this delay intentionally --- without it, it's way too easy for unintended menus to open as you move the mouse from one part of the page to another. I think I like it, but as always, feedback welcome. I'm expanding the ui-samples plugin to describe how it works and how to take advantages of this from plugins. On 02/28/2012 04:16 AM, Kohsuke Kawaguchi wrote: > The implementation is done in such a way that there's no extra data > loaded until you actually activate the menu (by hovering the mouse > over), so I think we are OK with this regard. > > 2012/2/24 Mirko Friedenhagen<[hidden email]>: >> My only concern would be to test this with bigger installations as well. >> When having 1000 jobs in one instance innocent looking 200 bytes of >> information per job may make a big difference :-D. >> >> Regards Mirko >> -- >> Sent from my phone >> http://illegalstateexception.blogspot.com >> http://github.com/mfriedenhagen/ >> https://bitbucket.org/mfriedenhagen/ >> >> On Feb 24, 2012 7:40 PM, "domi"<[hidden email]> wrote: >>> >>> I also think that having this option on every model object would be a >>> really good idea. >>> e.g. this could be useful in the executor list too >>> /Domi >>> >>> >>> On 24.02.2012, at 00:26, Kohsuke Kawaguchi wrote: >>> >>> > Hmm, that's interesting. It is relatively easy to build this on top of >>> > what we have. >>> > >>> > Definitely worth experimenting. Any thoughts on this from others? >>> > >>> > 2012/2/24 Dean Yu<[hidden email]>: >>> >> It would be great if the menu could be activated from any link to a >>> >> model >>> >> object, not just from the breadcrumb bar. For example, there have been >>> >> many >>> >> times I wished I could quickly jump to the configuration or console of >>> >> a job >>> >> from the upstream/downstream jobs section of a page. We could get rid >>> >> of a >>> >> lot of custom dashboard view columns if the menu could be activated >>> >> from the >>> >> links in the views. >>> >> >>> >> This would mean refactoring all model object links in Jelly files to >>> >> use a >>> >> modellink.jelly template, but it would be a consistent experience. >>> >> >>> >> -- Dean >>> >> >>> >> >>> >> On 2/20/12 7:15 PM , "Kohsuke Kawaguchi"<[hidden email]> >>> >> wrote: >>> >> >>> >>> As per the discussion in [1], I implemented the enhanced breadcrumb. >>> >>> The code is currently in a branch [2]. The screenshot is attached. >>> >>> >>> >>> Breadcrumb is now sticky --- when you scroll down, it sticks to the >>> >>> top of the page and never goes out of the viewport. Hovering the mouse >>> >>> over it will show the menu, and when you move your mouse out of the >>> >>> menu, it'll disappear automatically. The breadcrumb itself is still >>> >>> clickable as it has been. >>> >>> >>> >>> As you see in the screenshot, the breadcrumb now occupies more space >>> >>> (or easiler access to the context menu), and it's bordered. >>> >>> >>> >>> I'm not a UX guy, and I'm not too crazy about borders here (it appears >>> >>> somewhat out of style with the rest of Jenkins UI, although foldable >>> >>> sidepanel might change that.) With that said, I ended up adding it to >>> >>> create a boundary for sticky breadcrumb. >>> >>> >>> >>> Internally, it ses sidepanel.groovy/jelly to generate the menu >>> >>> contents by default, which lets us instantly activate this feature for >>> >>> all those objects that people have been writing. But model classes can >>> >>> override this behavior and completely take over the menu generation if >>> >>> so choose. >>> >>> >>> >>> Future enhancements include submenus. >>> >>> >>> >>> Does this sound like what we want? Feedbacks from graphics/UX guys >>> >>> (and I'm looking at Manfred!) would be especially appreciated. >>> >>> >>> >>> [1] >>> >>> >>> >>> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+n >>> >>> otes >>> >>> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb >>> >> >>> > >>> > >>> > >>> > -- >>> > Kohsuke Kawaguchi >>> >> > > > -- Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/ Try Nectar, our professional version of Jenkins |
|
Very nice!
-- Dean On 2/28/12 4:22 PM , "Kohsuke Kawaguchi" <[hidden email]> wrote: > > I've pushed this in > https://github.com/jenkinsci/jenkins/tree/breadcrumb > > Most of the list view links now support navigation menus (it's just a > matter of adding class='model-link' to the <a> tag), so you can get the > sense of how this behaves. > > You need to hover the mouse on <a> tags and wait for a bit before the > menu shows up. I added this delay intentionally --- without it, it's way > too easy for unintended menus to open as you move the mouse from one > part of the page to another. > > I think I like it, but as always, feedback welcome. > > I'm expanding the ui-samples plugin to describe how it works and how to > take advantages of this from plugins. > > On 02/28/2012 04:16 AM, Kohsuke Kawaguchi wrote: >> The implementation is done in such a way that there's no extra data >> loaded until you actually activate the menu (by hovering the mouse >> over), so I think we are OK with this regard. >> >> 2012/2/24 Mirko Friedenhagen<[hidden email]>: >>> My only concern would be to test this with bigger installations as well. >>> When having 1000 jobs in one instance innocent looking 200 bytes of >>> information per job may make a big difference :-D. >>> >>> Regards Mirko >>> -- >>> Sent from my phone >>> http://illegalstateexception.blogspot.com >>> http://github.com/mfriedenhagen/ >>> https://bitbucket.org/mfriedenhagen/ >>> >>> On Feb 24, 2012 7:40 PM, "domi"<[hidden email]> wrote: >>>> >>>> I also think that having this option on every model object would be a >>>> really good idea. >>>> e.g. this could be useful in the executor list too >>>> /Domi >>>> >>>> >>>> On 24.02.2012, at 00:26, Kohsuke Kawaguchi wrote: >>>> >>>>> Hmm, that's interesting. It is relatively easy to build this on top of >>>>> what we have. >>>>> >>>>> Definitely worth experimenting. Any thoughts on this from others? >>>>> >>>>> 2012/2/24 Dean Yu<[hidden email]>: >>>>>> It would be great if the menu could be activated from any link to a >>>>>> model >>>>>> object, not just from the breadcrumb bar. For example, there have been >>>>>> many >>>>>> times I wished I could quickly jump to the configuration or console of >>>>>> a job >>>>>> from the upstream/downstream jobs section of a page. We could get rid >>>>>> of a >>>>>> lot of custom dashboard view columns if the menu could be activated >>>>>> from the >>>>>> links in the views. >>>>>> >>>>>> This would mean refactoring all model object links in Jelly files to >>>>>> use a >>>>>> modellink.jelly template, but it would be a consistent experience. >>>>>> >>>>>> -- Dean >>>>>> >>>>>> >>>>>> On 2/20/12 7:15 PM , "Kohsuke Kawaguchi"<[hidden email]> >>>>>> wrote: >>>>>> >>>>>>> As per the discussion in [1], I implemented the enhanced breadcrumb. >>>>>>> The code is currently in a branch [2]. The screenshot is attached. >>>>>>> >>>>>>> Breadcrumb is now sticky --- when you scroll down, it sticks to the >>>>>>> top of the page and never goes out of the viewport. Hovering the mouse >>>>>>> over it will show the menu, and when you move your mouse out of the >>>>>>> menu, it'll disappear automatically. The breadcrumb itself is still >>>>>>> clickable as it has been. >>>>>>> >>>>>>> As you see in the screenshot, the breadcrumb now occupies more space >>>>>>> (or easiler access to the context menu), and it's bordered. >>>>>>> >>>>>>> I'm not a UX guy, and I'm not too crazy about borders here (it appears >>>>>>> somewhat out of style with the rest of Jenkins UI, although foldable >>>>>>> sidepanel might change that.) With that said, I ended up adding it to >>>>>>> create a boundary for sticky breadcrumb. >>>>>>> >>>>>>> Internally, it ses sidepanel.groovy/jelly to generate the menu >>>>>>> contents by default, which lets us instantly activate this feature for >>>>>>> all those objects that people have been writing. But model classes can >>>>>>> override this behavior and completely take over the menu generation if >>>>>>> so choose. >>>>>>> >>>>>>> Future enhancements include submenus. >>>>>>> >>>>>>> Does this sound like what we want? Feedbacks from graphics/UX guys >>>>>>> (and I'm looking at Manfred!) would be especially appreciated. >>>>>>> >>>>>>> [1] >>>>>>> >>>>>>> >>>>>>> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discus >>>>>>> sion+n >>>>>>> otes >>>>>>> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Kohsuke Kawaguchi >>>> >>> >> >> >> > |
|
In reply to this post by kohsuke Kawaguchi (CB)
Hello Kohsuke,
looks really nice! One small issue: - when using the menu from the dashboard hovering over one job name, there is the option to return to the dashboard, which seems superfluous to me :-). Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ https://bitbucket.org/mfriedenhagen/ On Wed, Feb 29, 2012 at 01:22, Kohsuke Kawaguchi <[hidden email]> wrote: > > I've pushed this in > https://github.com/jenkinsci/jenkins/tree/breadcrumb > > Most of the list view links now support navigation menus (it's just a matter > of adding class='model-link' to the <a> tag), so you can get the sense of > how this behaves. > > You need to hover the mouse on <a> tags and wait for a bit before the menu > shows up. I added this delay intentionally --- without it, it's way too easy > for unintended menus to open as you move the mouse from one part of the page > to another. > > I think I like it, but as always, feedback welcome. > > I'm expanding the ui-samples plugin to describe how it works and how to take > advantages of this from plugins. > > On 02/28/2012 04:16 AM, Kohsuke Kawaguchi wrote: >> >> The implementation is done in such a way that there's no extra data >> loaded until you actually activate the menu (by hovering the mouse >> over), so I think we are OK with this regard. >> >> 2012/2/24 Mirko Friedenhagen<[hidden email]>: >>> >>> My only concern would be to test this with bigger installations as well. >>> When having 1000 jobs in one instance innocent looking 200 bytes of >>> information per job may make a big difference :-D. >>> >>> Regards Mirko >>> -- >>> Sent from my phone >>> http://illegalstateexception.blogspot.com >>> http://github.com/mfriedenhagen/ >>> https://bitbucket.org/mfriedenhagen/ >>> >>> On Feb 24, 2012 7:40 PM, "domi"<[hidden email]> wrote: >>>> >>>> >>>> I also think that having this option on every model object would be a >>>> really good idea. >>>> e.g. this could be useful in the executor list too >>>> /Domi >>>> >>>> >>>> On 24.02.2012, at 00:26, Kohsuke Kawaguchi wrote: >>>> >>>> > Hmm, that's interesting. It is relatively easy to build this on top >>>> of >>>> > what we have. >>>> > >>>> > Definitely worth experimenting. Any thoughts on this from others? >>>> > >>>> > 2012/2/24 Dean Yu<[hidden email]>: >>>> >> It would be great if the menu could be activated from any link to a >>>> >> model >>>> >> object, not just from the breadcrumb bar. For example, there have >>>> been >>>> >> many >>>> >> times I wished I could quickly jump to the configuration or console >>>> of >>>> >> a job >>>> >> from the upstream/downstream jobs section of a page. We could get >>>> rid >>>> >> of a >>>> >> lot of custom dashboard view columns if the menu could be activated >>>> >> from the >>>> >> links in the views. >>>> >> >>>> >> This would mean refactoring all model object links in Jelly files >>>> to >>>> >> use a >>>> >> modellink.jelly template, but it would be a consistent experience. >>>> >> >>>> >> -- Dean >>>> >> >>>> >> >>>> >> On 2/20/12 7:15 PM , "Kohsuke Kawaguchi"<[hidden email]> >>>> >> wrote: >>>> >> >>>> >>> As per the discussion in [1], I implemented the enhanced >>>> breadcrumb. >>>> >>> The code is currently in a branch [2]. The screenshot is attached. >>>> >>> >>>> >>> Breadcrumb is now sticky --- when you scroll down, it sticks to >>>> the >>>> >>> top of the page and never goes out of the viewport. Hovering the >>>> mouse >>>> >>> over it will show the menu, and when you move your mouse out of >>>> the >>>> >>> menu, it'll disappear automatically. The breadcrumb itself is >>>> still >>>> >>> clickable as it has been. >>>> >>> >>>> >>> As you see in the screenshot, the breadcrumb now occupies more >>>> space >>>> >>> (or easiler access to the context menu), and it's bordered. >>>> >>> >>>> >>> I'm not a UX guy, and I'm not too crazy about borders here (it >>>> appears >>>> >>> somewhat out of style with the rest of Jenkins UI, although >>>> foldable >>>> >>> sidepanel might change that.) With that said, I ended up adding it >>>> to >>>> >>> create a boundary for sticky breadcrumb. >>>> >>> >>>> >>> Internally, it ses sidepanel.groovy/jelly to generate the menu >>>> >>> contents by default, which lets us instantly activate this feature >>>> for >>>> >>> all those objects that people have been writing. But model classes >>>> can >>>> >>> override this behavior and completely take over the menu >>>> generation if >>>> >>> so choose. >>>> >>> >>>> >>> Future enhancements include submenus. >>>> >>> >>>> >>> Does this sound like what we want? Feedbacks from graphics/UX guys >>>> >>> (and I'm looking at Manfred!) would be especially appreciated. >>>> >>> >>>> >>> [1] >>>> >>> >>>> >>> >>>> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+n >>>> >>> otes >>>> >>> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb >>>> >> >>>> > >>>> > >>>> > >>>> > -- >>>> > Kohsuke Kawaguchi >>>> >>> >> >> >> > > > -- > Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/ > Try Nectar, our professional version of Jenkins |
|
I've add contextMenu="false" to various <l:task> to get rid of some unwanted menu items. On 03/02/2012 03:29 PM, Mirko Friedenhagen wrote: > Hello Kohsuke, > > looks really nice! One small issue: > - when using the menu from the dashboard hovering over one job name, > there is the option to return to the dashboard, which seems > superfluous to me :-). > > Regards Mirko > -- > http://illegalstateexception.blogspot.com/ > https://github.com/mfriedenhagen/ > https://bitbucket.org/mfriedenhagen/ > > > > On Wed, Feb 29, 2012 at 01:22, Kohsuke Kawaguchi > <[hidden email]> wrote: >> >> I've pushed this in >> https://github.com/jenkinsci/jenkins/tree/breadcrumb >> >> Most of the list view links now support navigation menus (it's just a matter >> of adding class='model-link' to the<a> tag), so you can get the sense of >> how this behaves. >> >> You need to hover the mouse on<a> tags and wait for a bit before the menu >> shows up. I added this delay intentionally --- without it, it's way too easy >> for unintended menus to open as you move the mouse from one part of the page >> to another. >> >> I think I like it, but as always, feedback welcome. >> >> I'm expanding the ui-samples plugin to describe how it works and how to take >> advantages of this from plugins. >> >> On 02/28/2012 04:16 AM, Kohsuke Kawaguchi wrote: >>> >>> The implementation is done in such a way that there's no extra data >>> loaded until you actually activate the menu (by hovering the mouse >>> over), so I think we are OK with this regard. >>> >>> 2012/2/24 Mirko Friedenhagen<[hidden email]>: >>>> >>>> My only concern would be to test this with bigger installations as well. >>>> When having 1000 jobs in one instance innocent looking 200 bytes of >>>> information per job may make a big difference :-D. >>>> >>>> Regards Mirko >>>> -- >>>> Sent from my phone >>>> http://illegalstateexception.blogspot.com >>>> http://github.com/mfriedenhagen/ >>>> https://bitbucket.org/mfriedenhagen/ >>>> >>>> On Feb 24, 2012 7:40 PM, "domi"<[hidden email]> wrote: >>>>> >>>>> >>>>> I also think that having this option on every model object would be a >>>>> really good idea. >>>>> e.g. this could be useful in the executor list too >>>>> /Domi >>>>> >>>>> >>>>> On 24.02.2012, at 00:26, Kohsuke Kawaguchi wrote: >>>>> >>>>> > Hmm, that's interesting. It is relatively easy to build this on top >>>>> of >>>>> > what we have. >>>>> > >>>>> > Definitely worth experimenting. Any thoughts on this from others? >>>>> > >>>>> > 2012/2/24 Dean Yu<[hidden email]>: >>>>> >> It would be great if the menu could be activated from any link to a >>>>> >> model >>>>> >> object, not just from the breadcrumb bar. For example, there have >>>>> been >>>>> >> many >>>>> >> times I wished I could quickly jump to the configuration or console >>>>> of >>>>> >> a job >>>>> >> from the upstream/downstream jobs section of a page. We could get >>>>> rid >>>>> >> of a >>>>> >> lot of custom dashboard view columns if the menu could be activated >>>>> >> from the >>>>> >> links in the views. >>>>> >> >>>>> >> This would mean refactoring all model object links in Jelly files >>>>> to >>>>> >> use a >>>>> >> modellink.jelly template, but it would be a consistent experience. >>>>> >> >>>>> >> -- Dean >>>>> >> >>>>> >> >>>>> >> On 2/20/12 7:15 PM , "Kohsuke Kawaguchi"<[hidden email]> >>>>> >> wrote: >>>>> >> >>>>> >>> As per the discussion in [1], I implemented the enhanced >>>>> breadcrumb. >>>>> >>> The code is currently in a branch [2]. The screenshot is attached. >>>>> >>> >>>>> >>> Breadcrumb is now sticky --- when you scroll down, it sticks to >>>>> the >>>>> >>> top of the page and never goes out of the viewport. Hovering the >>>>> mouse >>>>> >>> over it will show the menu, and when you move your mouse out of >>>>> the >>>>> >>> menu, it'll disappear automatically. The breadcrumb itself is >>>>> still >>>>> >>> clickable as it has been. >>>>> >>> >>>>> >>> As you see in the screenshot, the breadcrumb now occupies more >>>>> space >>>>> >>> (or easiler access to the context menu), and it's bordered. >>>>> >>> >>>>> >>> I'm not a UX guy, and I'm not too crazy about borders here (it >>>>> appears >>>>> >>> somewhat out of style with the rest of Jenkins UI, although >>>>> foldable >>>>> >>> sidepanel might change that.) With that said, I ended up adding it >>>>> to >>>>> >>> create a boundary for sticky breadcrumb. >>>>> >>> >>>>> >>> Internally, it ses sidepanel.groovy/jelly to generate the menu >>>>> >>> contents by default, which lets us instantly activate this feature >>>>> for >>>>> >>> all those objects that people have been writing. But model classes >>>>> can >>>>> >>> override this behavior and completely take over the menu >>>>> generation if >>>>> >>> so choose. >>>>> >>> >>>>> >>> Future enhancements include submenus. >>>>> >>> >>>>> >>> Does this sound like what we want? Feedbacks from graphics/UX guys >>>>> >>> (and I'm looking at Manfred!) would be especially appreciated. >>>>> >>> >>>>> >>> [1] >>>>> >>> >>>>> >>> >>>>> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+n >>>>> >>> otes >>>>> >>> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb >>>>> >> >>>>> > >>>>> > >>>>> > >>>>> > -- >>>>> > Kohsuke Kawaguchi >>>>> >>>> >>> >>> >>> >> >> >> -- >> Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/ >> Try Nectar, our professional version of Jenkins > -- Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/ Try Nectar, our professional version of Jenkins |
|
In reply to this post by kohsuke Kawaguchi (CB)
Hi!
Really nice feature indeed. However I do get an JavaScript error using Internet Explorer 8, I should probably post this as a bug but I rumbled over this discussion and I've just wondering if anyone else has the same problem?
The problem appears when hovering the mouse over the breadcrumb to activate the menu. The error message recieved is:
Webpage error details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C; .NET4.0E)
Timestamp: Wed, 14 Mar 2012 12:08:12 UTC Message: 'left' is null or not an object. Line: 8 Char: 5672 Code: 0 URI: http://wsp0935c:8080/static/29830985/scripts/yui/dom/dom-min.js |
| Powered by Nabble | See how NAML generates this page |
