Pull Request Action

[Richard Bywater-2]

Hi

I've created a pull request against the Gradle plugin
(https://github.com/jenkinsci/gradle-plugin/pull/7) which allows one
to use the Gradle wrapper in a mixed Windows/Linux Master/Slave
set-up.

Just wondering what the best process is for getting a pull request
accepted? I have commit rights for plug-ins but don't think I should
be accepting my own pull requests :)

Thanks
Richard.

[Justin Ryan]

I reviewed it and it looks good, and commented as such. In this case, gboissinot pretty much owns the plugin. I'd give him a few days to accept it and a release a new version.

On Mon, Jul 30, 2012 at 5:31 AM, Richard Bywater <[hidden email]> wrote:

Hi

I've created a pull request against the Gradle plugin
(https://github.com/jenkinsci/gradle-plugin/pull/7) which allows one
to use the Gradle wrapper in a mixed Windows/Linux Master/Slave
set-up.

Just wondering what the best process is for getting a pull request
accepted? I have commit rights for plug-ins but don't think I should
be accepting my own pull requests :)

Thanks
Richard.

[Richard Bywater-2]

Awesome - thanks for the reply. Will give it a while and see if
gboissinot has time to accept or not...

Cheers
Richard.

On Wed, Aug 1, 2012 at 3:30 AM, Justin Ryan <[hidden email]> wrote:

> I reviewed it and it looks good, and commented as such. In this case,
> gboissinot pretty much owns the plugin. I'd give him a few days to accept it
> and a release a new version.
>
>
> On Mon, Jul 30, 2012 at 5:31 AM, Richard Bywater <[hidden email]> wrote:
>>
>> Hi
>>
>> I've created a pull request against the Gradle plugin
>> (https://github.com/jenkinsci/gradle-plugin/pull/7) which allows one
>> to use the Gradle wrapper in a mixed Windows/Linux Master/Slave
>> set-up.
>>
>> Just wondering what the best process is for getting a pull request
>> accepted? I have commit rights for plug-ins but don't think I should
>> be accepting my own pull requests :)
>>
>> Thanks
>> Richard.
>
>