Quantcast
Jenkins › Jenkins issues

[JIRA] (JENKINS-15576) LoadStatistics queue length and Cloud provisioning not working in conjunction with Node and Label parameter plugin

classic Classic list List threaded Threaded
♦
♦
 2 messages Options
JIRA noreply@jenkins-ci.org
Reply | Threaded
Open this post in threaded view
♦
♦
|  
Report Content as Inappropriate
♦
♦
star
♦
♦

[JIRA] (JENKINS-15576) LoadStatistics queue length and Cloud provisioning not working in conjunction with Node and Label parameter plugin

JIRA noreply@jenkins-ci.org
Issue Type: Bug Bug
Affects Versions: current
Assignee: domi
Components: core, nodelabelparameter
Created: 19/Oct/12 2:28 AM
Description:

The LoadStatistics.LoadStatisticsUpdater class updates the queueLength of each Label's LoadStatistics. It currently does the update by iterating over each of the BuildableItems in the queue and comparing their Task's assigned Label to the Label being updated and counting those that do (LoadStatistics.LoadStatisticsUpdater#count method).

The "Node and Label parameter plugin" allows the Label assigned to a job to be selected when starting the build or to be passed in by the "Jenkins Parameterized Trigger plugin". When this is used the Label on the Task is null, and the selected label is reflected on the BuildableItem in the queue itself.

This means that a Label selected using the Label parameter plugin always has LoadStatistics with a queue length of 0, and Cloud implementations are not requested to provision more nodes.

I have done some testing with the Label parameter plugin disabled (using the Groovy script below) and it appears that the Tasks and BuildableItems matching the label appear to be equal across the labels.

Jenkins j = Jenkins.getInstance();
List<hudson.model.Queue.BuildableItem> bis = j.getQueue().getBuildableItems();
println("Q length = " + bis.size());

for(Label l : j.getLabels())
{
  println(l.getExpression() + ":");
    
  int b=0,t=0;
  for (hudson.model.Queue.BuildableItem bi : bis) {
    if(bi.getAssignedLabel()==l)
          b++;
    if(bi.task.getAssignedLabel()==l)
          t++;
  }
  
  println("\tTasks matching label = " + t);
  println("\tBuilableItems matching label = " + b);
}

Is it correct that the LoadStatistics.LoadStatisticsUpdater#count method could be changed to call BuildableItem#getAssignedLabel rather than Task#getAssignedLabel?
Project: Jenkins
Priority: Major Major
Reporter: Laurence Hey
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
JIRA noreply@jenkins-ci.org
Reply | Threaded
Open this post in threaded view
♦
♦
|  
Report Content as Inappropriate
♦
♦
star
♦
♦

[JIRA] (JENKINS-15576) LoadStatistics queue length and Cloud provisioning not working in conjunction with Node and Label parameter plugin

JIRA noreply@jenkins-ci.org
Change By: Laurence Hey (15/Nov/12 6:32 AM)
Assignee: domi Laurence Hey
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Loading...
Powered by Nabble Edit this page