Jenkins › Jenkins issues

[JIRA] (JENKINS-15416) The CVS changes detector always does no filtering on selected branch or tag

Classic

List

13 messages Options

Options

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector always does no filtering on selected branch or tag

Issue Type:	Bug
Affects Versions:	current
Assignee:	Unassigned
Components:	cvs
Created:	05/Oct/12 9:25 AM
Description:	Bug found using the Jenkins CVS-Plugin version 2.6: The detection for changes for a CVS SCM is actually made with the cvs rlog command. The cvs rlog command does not set the revision option (-r) when polling HEAD or any other branches. If no -r option is applied all changes of all branches are detected! The cvs rlog option -r<branch> has always to be appended. If the Head is configured cvs rlog command has to use -rHEAD.
Environment:	SUSE Linux Enterprise Server 11 SP2 on x86-64
Fix Versions:	current
Project:	Jenkins
Labels:	plugin scm cvs
Priority:	Major
Reporter:	Daniel Fischer

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector always does no filtering on selected branch or tag

Do you have rlog output and the name of the branch you're building against? We don't apply -r since CvsLog does filtering according to version numbers so should filter out the changes we're not interested in.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector always does no filtering on selected branch or tag

In reply to this post by JIRA noreply@jenkins-ci.org

Please see attached file JENKINS-15416.zip . As you can see in included file hyperdoc-buildresources-HEAD\config.xml the HEAD is selected. The pollingLog file mentions a sourcecode change. The changes.htm shows one changed file /iqdoq/product/hyp4x/build/versno.properties with revision no 1.1307.2.18.2.41 . To verify that this revision was not checked in to the Head (branch) please see the screenshot file viewvc_screenshot_shows_commit_is_on_branch_hyp-5-3-1-branch_and_not_HEAD.png . The commit was done in branch hyp-5-3-1-branch (not HEAD). Also in jenkins.log I am getting numerous warnings like "#65188 warning C/S protocol error (section 5.10). It's regurarly observed with cvs 1.12.xx servers.".
Change By:	Daniel Fischer (09/Oct/12 8:24 AM)
Attachment:	JENKINS-15416.zip

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector always does no filtering on selected branch or tag

In reply to this post by JIRA noreply@jenkins-ci.org

I have copied the job hyperdoc-buildresources-HEAD for the build of another branch (hyp-5-4-0-branch). I have named the job hyperdoc-buildresources-5-4-0
If a commit is done out of that hyp-5-4-0-branch, the job hyperdoc-buildresources-5-4-0 detects no scm changes.
This leads me to the assumption that the scm changes detector only has problems if the job uses the CVS Head.

Perhaps the logic has to be changed that when Head is selected the changes detector has to filter out all branches rather than include a specific branch?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector always does no filtering on selected branch or tag

In reply to this post by JIRA noreply@jenkins-ci.org

The "It's regurarly observed with cvs 1.12.xx servers" warnings are your CVS server not following the CVS protocol properly (they don't set the path to CVS root in their response) and can be safely ignored if you're not having issues (I think we'd have to modify CVS Client if we wanted to prevent this message completely).

Are you able to provide the output of the rlog command for the period you were building? Feel free to obfuscate any sensitive values (repository names, paths, filenames etc) if needed. This would help greatly in recreating the issue and adding unit tests to prevent it re-occurring. Also, what comment is shown against the change if you select it on the changes page? Is it 'xxxx was originally added on branch xxxx'?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector always does no filtering on selected branch or tag

In reply to this post by JIRA noreply@jenkins-ci.org

Please see attached file cvs_rlog_out_hyperdoc-buildresources-HEAD-3.txt . I have simply 'replayed' the CVS rlog output command like that on the linux jenkins master command line: cvs rlog -S -d"05 Oct 2012 11:00:41 +0200<05 Oct 2012 16:00:53 +0200" iqdoq/product/hyp4x/build 2>&1> cvs_rlog_out_hyperdoc-buildresources-HEAD-3.txt
Change By:	Daniel Fischer (09/Oct/12 9:28 AM)
Attachment:	cvs_rlog_out_hyperdoc-buildresources-HEAD-3.txt

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector always does no filtering on selected branch or tag

In reply to this post by JIRA noreply@jenkins-ci.org

The comment on the changes page is:
Änderungen
Zusammenfassung

Autobuild: Release build hyp-5-3-1-28_442

autobuild:
Autobuild: Release build hyp-5-3-1-28_442
The file was modified 1.1307.2.18.2.41 /iqdoq/product/hyp4x/build/versno.properties

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector does not exclude changes outside of HEAD if SCM Location Head is selected

In reply to this post by JIRA noreply@jenkins-ci.org

Change By:	Daniel Fischer (09/Oct/12 10:14 AM)
Summary:	The CVS changes detector always does no filtering on not exclude changes outside of HEAD if SCM Location Head is selected branch or tag

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector does not exclude changes outside of HEAD if SCM Location Head is selected

In reply to this post by JIRA noreply@jenkins-ci.org

Change By:	Michael Clarke (09/Oct/12 7:59 PM)
Status:	Open In Progress

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector does not exclude changes outside of HEAD if SCM Location Head is selected

In reply to this post by JIRA noreply@jenkins-ci.org

Change By:	Michael Clarke (09/Oct/12 7:59 PM)
Assignee:	Michael Clarke

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector does not exclude changes outside of HEAD if SCM Location Head is selected

In reply to this post by JIRA noreply@jenkins-ci.org

Code changed in jenkins
User: Michael Clarke
Path:
src/main/java/hudson/scm/CvsLog.java
src/test/java/hudson/scm/CvsChangeLogHelperTest.java
src/test/resources/hudson/scm/cvsRlogOutputHead.txt
http://jenkins-ci.org/commit/cvs-plugin/1f8811272f1b5b6d0b25b7a9768a34dfb0895f75
Log:
[FIXED JENKINS-15416] Filter out non head changes if we're on head

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector does not exclude changes outside of HEAD if SCM Location Head is selected

In reply to this post by JIRA noreply@jenkins-ci.org

Change By:	SCM/JIRA link daemon (13/Oct/12 4:24 PM)
Status:	In Progress Resolved
Resolution:	Fixed

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-15416) The CVS changes detector does not exclude changes outside of HEAD if SCM Location Head is selected

In reply to this post by JIRA noreply@jenkins-ci.org

Fix verified with Jenkins CVS Plug-in version 2.7.
Change By:	Daniel Fischer (21/Nov/12 8:28 AM)
Status:	Resolved Closed

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Loading...