Quantcast

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
Issue Type: Bug Bug
Assignee: Bruno P. Kinoshita
Components: tap
Created: 04/Oct/12 3:02 PM
Description:

Quoting
http://testanything.org/wiki/index.php/TAP_version_13_specification#TODO_tests the spec says:

TODO tests

If the directive starts with # TODO, the test is counted as a todo test, and the text after TODO is the explanation.

not ok 13 # TODO bend space and time

Note that if the TODO has an explanation it must be separated from TODO by a space.

These tests represent a feature to be implemented or a bug to be fixed and act as something of an executable "things to do" list. They are not expected to succeed. Should a todo test point begin succeeding, the harness should report it as a bonus. This indicates that whatever you were supposed to do has been done and you should promote this to a normal test point.

AFAICT the TAP plugin doesn't seem to take care of the TODO directive accordingly though, therefore marking test runs as failures even though they should be fine.

Example:

http://michael-prokop.at/screeni/gkrellShoot_12-10-04_165641.png

Project: Jenkins
Labels: tap
Priority: Major Major
Reporter: Michael Prokop
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org

+1 thanks for reporting this issue Michael.

I'll add an option so that users can decide whether a TODO directive should be interpreted as failed or not. The default behavior will be follow the TAP specification, as you mentioned in the issue description.

Does that sound like a good idea for you?

Cheers, B

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Change By: Bruno P. Kinoshita (12/Oct/12 7:22 PM)
Status: Open In Progress
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Hi Bruno,

this sounds fantastic

Thanks for taking care!

regards,
Michael

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Change By: Bruno P. Kinoshita (25/Nov/12 4:22 AM)
Status: In Progress Open
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Bruno P. Kinoshita resolved Bug JENKINS-15401 as Fixed
Change By: Bruno P. Kinoshita (25/Nov/12 4:23 AM)
Status: Open Resolved
Resolution: Fixed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Hi Bruno,

thanks for implementing this feature. Is there any chance that you might release a new version of the TAP plugin soon?

thanks && regards,
Michael

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Hi Michael! Sorry!!!! I couldn't release the plug-in live at Jenkins Meetup Sao Paulo (technical problems with my graphic card).

I'll try to release a new version tonight.

Sorry again.
Bruno

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Hi Bruno, no reason to be sorry Thanks a lot, very much looking forward to the new TAP plugin release!

regards,
Michael

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-15401) support TODO directive to not fail such tests

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Fixed in 1.8. This version will be available from update manager within few hours.

Change By: Bruno P. Kinoshita (19/Dec/12 1:01 AM)
Status: Resolved Closed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Loading...