[JIRA] (JENKINS-15367) Jenkins kicks off the wrong downstream builds for Maven

Jay Meyer created JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Issue Type:	Bug
Affects Versions:	current
Assignee:	Unassigned
Components:	maven
Created:	01/Oct/12 2:50 PM
Description:	Given: Jenkins has different build jobs with different versions of the same artifacts and group ids. Example jarProj-1.1 and jarProj-1.2, and dependent builds warProj-1.1 and warProj-1.2. Problem: When Jenkins determines downstream build jobs, it is choosing ALL versions of old and current jobs. So in the example, jarProj-1.2 kicks off BOTH warProj-1.2 (correct) AND warProj1.1 (incorrect). Also, jarProj-1.1 kicks off no builds at all (incorrect), when instead we expect it to kick off warProj-1.1. Seems related to JENKINS-15295. We have the same fingerprint errors. Also, JENKINS-12735 made a change to cover version ranges in Maven, and that seems like it would break the downstream builds if a bug was introduced there.
Project:	Jenkins
Priority:	Critical
Reporter:	Jay Meyer

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jay Meyer updated JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Change By:	Jay Meyer (01/Oct/12 3:02 PM)
Component/s:	maven-dependency-update-trigger
Component/s:	maven2

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Larry Shatzer, Jr. commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

See this thread https://groups.google.com/forum/?fromgroups=#!topic/jenkinsci-dev/sPD02rg0ZCQ

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Kohsuke Kawaguchi assigned JENKINS-15367 to Kohsuke Kawaguchi

Jenkins kicks off the wrong downstream builds for Maven

Change By:	Kohsuke Kawaguchi (15/Oct/12 6:38 PM)
Assignee:	Kohsuke Kawaguchi

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

Marco Rothe edited a comment on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

It seems to be related to (or a dublicate of) 15237. This is a real blocker for us and we downgraded to 1.480.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

Marco Rothe edited a comment on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

It seems to be related to (or a dublicate of) this #15237. This is a real blocker for us and we downgraded to 1.480.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

Alex Koon updated JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

I have traced this issue as part of https://issues.jenkins-ci.org/browse/JENKINS-12735 I have added a test case to MavenModuleTest to show this and a fix for this in ModuleDependency. I have pushed this to my fork on github at https://github.com/alexkoon/jenkins and the commit is at https://github.com/alexkoon/jenkins/commit/4043905580df5bf22cde0eaf3dec103abdc88017 I can issue a pull request for this if you wish.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Michael Glauche commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Hi, I did try out your fork, and it seems to work fine for my scenarios. (i.e. direct snapshot dependencies got triggered, other versions didn't)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Erik Riemers commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Would be nice to see this in 1.491 or newer.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Code changed in jenkins User: alexkoon Path: maven-plugin/src/main/java/hudson/maven/ModuleDependency.java maven-plugin/src/test/java/hudson/maven/MavenModuleTest.java http://jenkins-ci.org/commit/jenkins/4043905580df5bf22cde0eaf3dec103abdc88017 Log: JENKINS-15367 Fix for downstream dependencies when we have a specified version (not a version range).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Code changed in jenkins User: Olivier Lamy Path: maven-plugin/src/main/java/hudson/maven/ModuleDependency.java maven-plugin/src/test/java/hudson/maven/MavenModuleTest.java http://jenkins-ci.org/commit/jenkins/2c469b37b563c5d6ca70ac7841897e1a20083130 Log: Merge pull request #609 from alexkoon/master JENKINS-15367 Fix Maven downstream resolution when declared as a specific version. Compare: https://github.com/jenkinsci/jenkins/compare/7bf6c5ca6e09...2c469b37b563

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Code changed in jenkins User: Olivier Lamy Path: changelog.html http://jenkins-ci.org/commit/jenkins/2dbf8c5bce22f557834f5802cc379566addb9b7a Log: changelog entry for JENKINS-15367

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

tuomas_kiviaho commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

For me it seems to see itself somehow though version ranges (caused by cyclic dependencies I guess) and stays forever in 'pending - Upstream Job ... in build queue'. This might be more related to JENKINS-12735 because it started to happen at the same time that (upstream and) downstream builds started to contain version ranged dependencies. Funny thing is that the project itself isn't listed in upstream builds.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Arnaud Héritier commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

The problem always exists in 1.491 To reproduce add these 2 projects in your jenkins : https://github.com/vietj/chromattic https://github.com/vietj/wikbook Wikbook builds will trigger chromattic builds while chromattic uses a released version of wikbook

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Larry Shatzer, Jr. commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

This was committed after the 1.491 RC branch was created, and was not backported into the RC branch unfortunately. It will be in 1.492.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Julien Carsique commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Successfully tested on 1.491 with a cherry-pick of 4043905580df5bf22cde0eaf3dec103abdc88017 I tried with https://github.com/nuxeo/nuxeo-common/ and https://github.com/nuxeo/nuxeo-runtime/ with their "master" and "5.6.0" branches. I couldn't try much more with https://github.com/vietj/chromattic and https://github.com/vietj/wikbook because of build issues but it seems fine on the POM parsing part. Before the fix, nuxeo-common master (version 5.7-SNAPSHOT) was triggering nuxeo-runtime master (version 5.7-SNAPSHOT) and 5.6.0 (version 5.6.0-HF04-SNAPSHOT), whereas nuxeo-common 5.6.0 was triggering nothing at all. Note I didn't try to reproduce the issue with chromattic and wikbook before the fix. However, even if the triggering is fixed, I still have an issue (I don't know if it's exactly the same issue): relationship between builds is sticked at builds earlier the fix if there was no build before the fix, then the relationship is empty I'm talking about jenkins/projectRelationship?lhs=nuxeo-common-5.6.0&rhs=nuxeo-runtime-5.6.0 and jenkins/projectRelationship?lhs=nuxeo-common-master&rhs=nuxeo-runtime-master Before 1.480, the relationship is right. Since 1.481 until 1.491, without the current fix, the relationship seems still right even if triggering is wrong (see comment-168178 on JENKINS-15237). With the current fix applied on 1.491, the relationship is no more updated (new builds are ignored). Of course, that new issue appears on the summary views: upstream/downstream information on jobs is right whereas upstream/downstream information on builds is simply missing.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jesse Glick assigned JENKINS-15367 to olamy

Jenkins kicks off the wrong downstream builds for Maven

Should this now be resolved as fixed?
Change By:	Jesse Glick (03/Dec/12 4:05 PM)
Assignee:	Kohsuke Kawaguchi olamy

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

olamy commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

It looks yes. I didn't notice more complain

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Erik Riemers commented on JENKINS-15367

Jenkins kicks off the wrong downstream builds for Maven

Seems to have done it on our end. Had no complaints either.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jay Meyer resolved JENKINS-15367 as Fixed

Jenkins kicks off the wrong downstream builds for Maven

Fixed in 1.492. I have not verified this myself, but I trust the word of others who have verified this. I have scheduled to try this on my builds the week of Dec-10. If it fails again, I will re-open this issue with the details of the failure.
Change By:	Jay Meyer (03/Dec/12 5:01 PM)
Status:	Open Resolved
Resolution:	Fixed

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira