[JIRA] (JENKINS-15197) Add support for Maven toolchains configuration file

Jeff MAURY created JENKINS-15197

Add support for Maven toolchains configuration file

Issue Type:	Improvement
Affects Versions:	current
Assignee:	domi
Components:	config-file-provider
Created:	17/Sep/12 1:22 PM
Description:	Maven3 supports a new option for specifiying toolchains mechanism. It would be nice if this could be managed in Jenkins like the other Maven configuration files (settings, global settings)
Fix Versions:	current
Project:	Jenkins
Labels:	configuration Maven
Priority:	Minor
Reporter:	Jeff MAURY

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jeff MAURY commented on JENKINS-15197

Add support for Maven toolchains configuration file

I will submit a patch in the following days

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

domi commented on JENKINS-15197

Add support for Maven toolchains configuration file

Thanks Jeff, this is a really good idea! Nicolas currently is also working on the same code to make it more plugable in the core itself (the settings.xml) he needs a different implementation of this for cloudbees, therefore we want to have this as a clean EP in the core. His current state is here: https://github.com/ndeloof/jenkins/tree/maven-settings Maybe it would make sense to have your idea integrated into that change as well. wdyt?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jeff MAURY commented on JENKINS-15197

Add support for Maven toolchains configuration file

Domi, I looked at the code and it sems the philosphy is that you can plug several settings source implementations, the one Nicolas did is file based. So I think it is not incompatible with the file-provider-plugin as we probably need an implementation for file-provider-plugin as it allow settings sharing between jobs. So I suggest the following: 1) I send a pull request to file-provider-plugin to support toolchains config files 2) I send another pull request to jenkins (maven plugin) to handle those toolchains config files 3) I will open a JIRA to support file-provider plugin the new way, adding a new implementation, and adding toolchains support as well (btw, it seems nicolas's work is not complete as it does not support global settings and I don't know if it is merged in master)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-15197

Add support for Maven toolchains configuration file

Code changed in jenkins User: Olivier Lamy Path: src/main/java/org/jenkinsci/plugins/configfiles/buildwrapper/CleanTempFilesAction.java src/main/java/org/jenkinsci/plugins/configfiles/buildwrapper/CleanTempFilesRunListener.java src/main/java/org/jenkinsci/plugins/configfiles/buildwrapper/ManagedFileUtil.java src/main/java/org/jenkinsci/plugins/configfiles/custom/CustomConfig.java src/main/java/org/jenkinsci/plugins/configfiles/groovy/GroovyScript.java src/main/java/org/jenkinsci/plugins/configfiles/maven/GlobalMavenSettingsConfig.java src/main/java/org/jenkinsci/plugins/configfiles/maven/MavenSettingsConfig.java src/main/java/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig.java src/main/java/org/jenkinsci/plugins/configfiles/xml/XmlConfig.java src/main/resources/org/jenkinsci/plugins/configfiles/Messages.properties src/main/resources/org/jenkinsci/plugins/configfiles/Messages_fr.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail.jelly src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail_fr.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/toolchains-tpl.xml http://jenkins-ci.org/commit/config-file-provider-plugin/436eecab1103850d04f9d9b463169099c7f8e57a Log: Merge pull request #3 from jeffmaury/JENKINS-15197 JENKINS-15197 Add support for Maven toolchains config files Thanks ! Compare: https://github.com/jenkinsci/config-file-provider-plugin/compare/467091e6a416...436eecab1103

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-15197

Add support for Maven toolchains configuration file

Code changed in jenkins User: Jeff MAURY Path: src/main/java/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig.java src/main/resources/org/jenkinsci/plugins/configfiles/Messages.properties src/main/resources/org/jenkinsci/plugins/configfiles/Messages_fr.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail.jelly src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail_fr.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/toolchains-tpl.xml http://jenkins-ci.org/commit/config-file-provider-plugin/23fcf58e4646e5eb54459745e6b352bbb4d24fb7 Log: JENKINS-15197 Add support for Maven toolchains config files

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-15197

Add support for Maven toolchains configuration file

Code changed in jenkins User: Olivier Lamy Path: src/main/java/org/jenkinsci/plugins/configfiles/buildwrapper/CleanTempFilesAction.java src/main/java/org/jenkinsci/plugins/configfiles/buildwrapper/CleanTempFilesRunListener.java src/main/java/org/jenkinsci/plugins/configfiles/buildwrapper/ManagedFileUtil.java src/main/java/org/jenkinsci/plugins/configfiles/custom/CustomConfig.java src/main/java/org/jenkinsci/plugins/configfiles/groovy/GroovyScript.java src/main/java/org/jenkinsci/plugins/configfiles/maven/GlobalMavenSettingsConfig.java src/main/java/org/jenkinsci/plugins/configfiles/maven/MavenSettingsConfig.java src/main/java/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig.java src/main/java/org/jenkinsci/plugins/configfiles/xml/XmlConfig.java src/main/resources/org/jenkinsci/plugins/configfiles/Messages.properties src/main/resources/org/jenkinsci/plugins/configfiles/Messages_fr.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail.jelly src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail_fr.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/toolchains-tpl.xml http://jenkins-ci.org/commit/config-file-provider-plugin/aac2af9b779b4574b68cfe189182e4b90d091630 Log: Merge pull request #3 from jeffmaury/JENKINS-15197 JENKINS-15197 Add support for Maven toolchains config files Thanks !

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-15197

Add support for Maven toolchains configuration file

Code changed in jenkins User: Jeff MAURY Path: src/main/java/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig.java src/main/resources/org/jenkinsci/plugins/configfiles/Messages.properties src/main/resources/org/jenkinsci/plugins/configfiles/Messages_fr.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail.jelly src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/MavenToolchainsConfig/MavenToolchainsConfigProvider/newInstanceDetail_fr.properties src/main/resources/org/jenkinsci/plugins/configfiles/maven/toolchains-tpl.xml http://jenkins-ci.org/commit/config-file-provider-plugin/8f6240a98a16cd433640e69056885219a1f424fe Log: JENKINS-15197 Add support for Maven toolchains config files

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

domi resolved JENKINS-15197 as Fixed

Add support for Maven toolchains configuration file

integrated in version 2.3
Change By:	domi (02/Dec/12 5:43 PM)
Status:	Open Resolved
Resolution:	Fixed

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira