Quantcast

[JIRA] (JENKINS-14845) Default "SUCCESS" status reported when no results are found is wrong

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-14845) Default "SUCCESS" status reported when no results are found is wrong

JIRA noreply@jenkins-ci.org
Issue Type: Improvement Improvement
Affects Versions: current
Assignee: Bruno P. Kinoshita
Components: testlink
Created: 17/Aug/12 1:46 PM
Description:

In the console example below:

"Found 0 test result(s).
Updating TestLink test cases.
No emails were triggered.
Finished: SUCCESS"

we can see that when no test results are found, the test link plug-in reports a "SUCCESS" status. I think it's wrong and a "FAILURE" status should be reported instead.

Fix proposal:
Just adding:
if (report.getTestsTotal()==0) { build.setResult(Result.FAILURE); }

in src/main/java/hudson/plugins/testlink/TestLinkBuilder.java
at the end of the perform method is sufficient in my case.

Best Regards,
Oscar

Project: Jenkins
Priority: Minor Minor
Reporter: oscar francois
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-14845) Default "SUCCESS" status reported when no results are found is wrong

JIRA noreply@jenkins-ci.org
Change By: Bruno P. Kinoshita (10/Sep/12 11:38 PM)
Status: Open In Progress
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-14845) Default "SUCCESS" status reported when no results are found is wrong

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org
Change By: SCM/JIRA link daemon (11/Sep/12 12:34 AM)
Status: In Progress Resolved
Resolution: Fixed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-14845) Default "SUCCESS" status reported when no results are found is wrong

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Code changed in jenkins
User: Bruno P. Kinoshita
Path:
src/main/java/hudson/plugins/testlink/AbstractTestLinkBuilder.java
src/main/java/hudson/plugins/testlink/TestLinkBuilder.java
src/main/resources/hudson/plugins/testlink/TestLinkBuilder/config.jelly
src/main/resources/hudson/plugins/testlink/TestLinkBuilder/config.properties
src/main/resources/hudson/plugins/testlink/TestLinkBuilder/config_es.properties
src/main/resources/hudson/plugins/testlink/TestLinkBuilder/config_pt.properties
src/main/webapp/help-failIfNoResults.html
src/main/webapp/help-failIfNoResults_es.html
src/main/webapp/help-failIfNoResults_pt.html
src/test/java/hudson/plugins/testlink/TestTestLinkBuilder.java
http://jenkins-ci.org/commit/testlink-plugin/82cfc780f3a10a3c14cc1946c3b15170223a70cf
Log:
[FIXED JENKINS-14845] Added an option under the advanced section to set the
build result to FAILURE when no test results are present.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-14845) Default "SUCCESS" status reported when no results are found is wrong

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

Fixed in 3.1.7 (available from update-center in the next hours)

Change By: Bruno P. Kinoshita (19/Sep/12 3:54 PM)
Status: Resolved Closed
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Loading...