[JIRA] (JENKINS-14619) Matrix problem with Parameterized Build

morlajb created JENKINS-14619

Matrix problem with Parameterized Build

Issue Type:	Bug
Assignee:	huybrechts
Components:	parameterized-trigger
Created:	29/Jul/12 12:26 PM
Description:	The main project use the correct SVN revision, but all the configurations use the latest version , this can cause incompatibility with complex jobs.
Project:	Jenkins
Priority:	Critical
Reporter:	morlajb

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

cjo9900 commented on JENKINS-14619

Matrix problem with Parameterized Build

Can you describe the issue in more detail please. How is the trigger configured? What type of job is being triggered? Can you give config file examples showing this? (create test project(s) with a public OSS repo if needed). Thanks.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

cjo9900 commented on JENKINS-14619

Matrix problem with Parameterized Build

For your comments, I think what you mean is you have ProjectA -> ProjectB(matrix parent) -> Configuration(1-n) And revisions seen are ProjectA has Revision 3, ProjectB(parent) has Revision 3 Configurations(1-n) have Revision HEAD If this is the case, it looks like the issue is with the matrix project not passing all of the actions to it configurations, only Parameter Actions. Caused by the following items of code: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java#L200 https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/matrix/MatrixConfiguration.java#L358 So this interface needs to be more generic to allow other actions to be passed along. As this may also affect the EnvInjectAction if this is passed along. However all actions should not passed directly as some do not make sense to pass.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

morlajb commented on JENKINS-14619

Matrix problem with Parameterized Build

Hi , Thanks for your reply , I wasn't in the office in the last days. you are right this is exactly the configuration I used.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

morlajb edited a comment on JENKINS-14619

Matrix problem with Parameterized Build

Hi , Thanks for your reply , I wasn't in the office in the last days. you are right this is exactly the configuration I used. here is the log of the matrix job : 15:10:37 U management\flow-triggering\oo-flow-triggering-api\pom.xml 15:11:13 At revision 10313 and all the activate jobs shows the following : 15:12:01 U management\l10n\oo-l10n-ja\src\main\resources\deployment_ja.properties 15:14:01 At revision 10317 I was trying to add the config file and couldn't find the way ...

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

morlajb updated JENKINS-14619

Matrix problem with Parameterized Build

Change By:	morlajb (08/Aug/12 11:30 AM)
Attachment:	config.xml

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

morlajb edited a comment on JENKINS-14619

Matrix problem with Parameterized Build

here is the config.xml contains the problem. do you need any more info for this problem ?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

morlajb updated JENKINS-14619

Matrix problem with Parameterized Build

here is the config.xml contains the problem.
Change By:	morlajb (08/Aug/12 11:29 AM)
Attachment:	config.xml

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

morlajb edited a comment on JENKINS-14619

Matrix problem with Parameterized Build

Hi , Thanks for your reply , I wasn't in the office in the last days. you are right this is exactly the configuration I used. here is the log of the matrix job : 15:10:37 U management\flow-triggering\oo-flow-triggering-api\pom.xml 15:11:13 At revision 10313 and all the activate jobs shows the following : 15:12:01 U management\l10n\oo-l10n-ja\src\main\resources\deployment_ja.properties 15:14:01 At revision 10317

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

cjo9900 updated JENKINS-14619

Matrix problem with Parameterized Build

This is a problem with all actions that should be passed to the matrix configurations. See mailing list item https://groups.google.com/d/topic/jenkinsci-dev/h3TMwZ-qmDQ/discussion I would propose adding all actions from parent build to the all of the configurations, but are there any issues doing this? I.e. actions should not be passed on.(MatrixSubsetAction in parameterized-trigger) So should there be an interface that actions implement to indicate that they are passed from the parent to the configurations? that the Matrix configuration can use to filter the actions passed to it. Or are there any better suggestions? [1] https://issues.jenkins-ci.org/browse/JENKINS-14619 [2] https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/matrix/MatrixConfiguration.java#L358 [3] https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java#L200
Change By:	cjo9900 (15/Aug/12 1:53 PM)
Component/s:	matrix

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

mor lajb commented on JENKINS-14619

Matrix problem with Parameterized Build

i think that your solution is the right one. How can I help you to implement it ?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-14619

Matrix problem with Parameterized Build

Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java core/src/main/java/hudson/matrix/MatrixChildAction.java core/src/main/java/hudson/matrix/MatrixConfiguration.java core/src/main/java/hudson/model/ParametersAction.java test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy http://jenkins-ci.org/commit/jenkins/f250ead3b58dcbfa42e788bf71d6019627eb2950 Log: Create a marker interface for actions to beable to pass matrix configurations create a Interface that Actions can implement to indicat that they should be passed from the matrix parent to the indiviual configurations. This means that the SVN Parameters can be passed to them. Partial fix for JENKINS-14619 also needs changes in SVN SCM plugin to fix completely. Developed by cjo9900

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

cjo9900 commented on JENKINS-14619

Matrix problem with Parameterized Build

Pull request on SVN plugin to complete the changes https://github.com/jenkinsci/subversion-plugin/pull/20

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira