[JIRA] (JENKINS-14582) Missing pop-up window for a commit message in SCM Sync

Julien Carsique created JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

Issue Type:	Bug
Assignee:	Julien Carsique
Components:	scm-sync-configuration
Created:	26/Jul/12 12:50 PM
Description:	Most of the time, there is no pop-up window suggesting to fill a commit message. At the end, when the popup window works, the commit message is << Modification on file by jcarsique with following comment : >> even if the user message is empty; whereas when the issue happens, the commit message is << Modification on file by jcarsique >>. Note there's a "tabulation" character between the two words "following" and "comment" instead of a regular space, and there should be no space before the ending colon ":" (English rule versus French one).
Project:	Jenkins
Priority:	Major
Reporter:	Julien Carsique

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Julien Carsique assigned JENKINS-14582 to Frédéric Camblor

Missing pop-up window for a commit message in SCM Sync

Change By:	Julien Carsique (26/Jul/12 12:50 PM)
Assignee:	Julien Carsique Frédéric Camblor

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Frédéric Camblor commented on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

Can you paste here urls where it happens ?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Julien Carsique commented on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

It seems to work on the global configuration and it happens on all jobs' configuration. It's a Jenkins 1.472 with SCM Sync 0.0.5. The Jenkins is public (https://qa.nuxeo.org) but you won't have access to the job configuration, nor the conf repository. I don't see any relevant information in the logs (set to the finest level for hudson.plugins.scm_sync_configuration). What kind of URLs do you want?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Frédéric Camblor commented on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

Configuration url. Commit dialog will appear depending on current browser url (I use regexes for that). You could eventually be in a case where I missed something (for example, in the past, configuring your jobs trough a view was done on /MyView/MyJob/configure ... and it was not taken into account because regex was only matching with /*/configure) Maybe you're in such a case.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

Frédéric Camblor edited a comment on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

Configuration url. Commit dialog will appear depending on current browser url (I use regexes for that). You could eventually be in a case where I missed something (for example, in the past, configuring your jobs trough a view was done on /MyView/jobs/MyJob/configure ... and it was not taken into account because regex was only matching with /jobs/*/configure) Maybe you're in such a case.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

Frédéric Camblor edited a comment on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

Configuration url. Commit dialog will appear depending on current browser url (I use regexes for that). You could eventually be in a case where I missed something (for example, in the past, configuring your jobs trough a view was done on /view/MyView/job/MyJob/configure ... and it was not taken into account because regex was only matching with /job/*/configure) Maybe you're in such a case.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Frédéric Camblor commented on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

Another possibility is the form name changed in your version. Could you try to execute following jquery selector on configuration page (in a js debuuger) : $("form[name='config']") to see if it returns something ? FYI, jobs strategy info is described here

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

Frédéric Camblor edited a comment on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

Another possibility is the form name changed in your version. Could you try to execute following jquery selector on configuration page (in a js debugger) : $("form[name='config']") to see if it returns something ? FYI, jobs strategy info is described here

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Julien Carsique commented on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

You're right about the URL: I'm used to browse starting from the default dashboard view (https://qa.nuxeo.org/jenkins/) which has no "view/..." in its URL. So far, here are the results: the form name has not changed >>> $$("form[name=config]") [form configSubmit] the "Apply" button never triggers the SCM Sync whereas the "Save" button does the REGEXP ^(.*view/[^/]+/)?job/[^/]+/configure$ does not match URLs without a view (that's the case when using the default Dashboard view). Using ^(.*[^/]+/)?job/[^/]+/configure$ would match.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Frédéric Camblor commented on JENKINS-14582

Missing pop-up window for a commit message in SCM Sync

I don't think so, ^(.*view/[^/]+/)?job/[^/]+/configure$ matches job/blah/configure (view fragment is in a conditionnal regex) What I think is you have a contextUrl which is not empty... I should look at this this evening, but I think the url tested is not job/blah/configure in your case, but jenkins/job/blah/configure (which obviously doesn't match regex ) I should remove current contextUrl from url if this is not already done !

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Frédéric Camblor updated JENKINS-14582

No popup window if contextPath different from /

Rephrased issue because reproduced : url matching (and thus, display of popup) doesn't work if jenkins server has a context I don't know how you succeeded to have the popup window though
Change By:	Frédéric Camblor (26/Jul/12 9:50 PM)
Summary:	Missing pop-up No popup  window  for a commit message in SCM Sync  if contextPath different from /
Environment:	scm-sync-config 0.0.6
Description:	On [nuxeo instance|https://qa.nuxeo.org/jenkins/], having a contextpath (jenkins/), scm sync popup window doesn't work because rootUrl = https://qa.nuxeo.org/, thus, url to test for config page, for instance, is jenkins/configure : doesn't match the ^configure$ regex. _Original message : Most of the time, there is no pop-up window suggesting to fill a commit message. At the end, when the popup window works, the commit message is << Modification on file by jcarsique with following comment : >> even if the user message is empty; whereas when the issue happens, the commit message is << Modification on file by jcarsique >>. Note there's a "tabulation" character between the two words "following" and "comment" instead of a regular space, and there should be no space before the ending colon ":" (English rule versus French one). _

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Frédéric Camblor resolved JENKINS-14582 as Fixed

No popup window if contextPath different from /

issue fixed. will be shipped in 0.0.7
Change By:	Frédéric Camblor (26/Jul/12 10:12 PM)
Status:	Open Resolved
Resolution:	Fixed

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-14582

No popup window if contextPath different from /

Code changed in jenkins User: Frédéric Camblor Path: src/main/java/hudson/plugins/scm_sync_configuration/strategies/AbstractScmSyncStrategy.java http://jenkins-ci.org/commit/scm-sync-configuration-plugin/59cf7df85136c2f40760301e738ace79fd402c4b Log: fixed JENKINS-14582 by using Hudson.getInstance().getRootUrlFromRequest() instead of getRootUrl() (the first one returns context path when present)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira