[JIRA] (JENKINS-13822) Maven plugin: expand variables in "Room POM" field

Ian Kemp created JENKINS-13822:
----------------------------------

             Summary: Maven plugin: expand variables in "Room POM" field
                 Key: JENKINS-13822
                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
             Project: Jenkins
          Issue Type: Improvement
          Components: maven
            Reporter: Ian Kemp
            Priority: Trivial


The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.

I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Kemp reassigned JENKINS-13822:
----------------------------------

    Assignee: Ian Kemp
   

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Ian Kemp
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on JENKINS-13822 started by Ian Kemp.

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Ian Kemp
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=163065#comment-163065 ]

Ian Kemp commented on JENKINS-13822:
------------------------------------

Fixed and pull request sent.
               

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Ian Kemp
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Kemp reassigned JENKINS-13822:
----------------------------------

    Assignee: Kohsuke Kawaguchi  (was: Ian Kemp)
   

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Kohsuke Kawaguchi
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=163070#comment-163070 ]

SCM/JIRA link daemon commented on JENKINS-13822:
------------------------------------------------

Code changed in jenkins
User: IanKemp
Path:
 maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java
 maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
http://jenkins-ci.org/commit/jenkins/4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0
Log:
  Fixes JENKINS-13822: expand variables in "Root POM" field of Maven plugin



               

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Kohsuke Kawaguchi
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=163071#comment-163071 ]

SCM/JIRA link daemon commented on JENKINS-13822:
------------------------------------------------

Code changed in jenkins
User: Olivier Lamy
Path:
 maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java
 maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
http://jenkins-ci.org/commit/jenkins/ec9d403c63131206d9ca4a77c4c90ffb190129d8
Log:
  Merge pull request #480 from IanKemp/master

[JENKINS-13822] fix
Thanks


Compare: https://github.com/jenkinsci/jenkins/compare/6e58e07...ec9d403


               

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Kohsuke Kawaguchi
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=163072#comment-163072 ]

SCM/JIRA link daemon commented on JENKINS-13822:
------------------------------------------------

Code changed in jenkins
User: Olivier Lamy
Path:
 changelog.html
http://jenkins-ci.org/commit/jenkins/25b694351f68076129734604dd270ae48f31b020
Log:
  changelog entry for [JENKINS-13822]





               

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Kohsuke Kawaguchi
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=163074#comment-163074 ]

dogfood commented on JENKINS-13822:
-----------------------------------

Integrated in !http://ci.jenkins-ci.org/images/16x16/blue.png! [jenkins_main_trunk #1725|http://ci.jenkins-ci.org/job/jenkins_main_trunk/1725/]
     Fixes JENKINS-13822: expand variables in "Root POM" field of Maven plugin (Revision 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0)
changelog entry for [JENKINS-13822] (Revision 25b694351f68076129734604dd270ae48f31b020)

     Result = SUCCESS
ian.kemp : [4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0|https://github.com/jenkinsci/jenkins/commit/4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0]
Files :
* maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
* maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java

Olivier Lamy : [25b694351f68076129734604dd270ae48f31b020|https://github.com/jenkinsci/jenkins/commit/25b694351f68076129734604dd270ae48f31b020]
Files :
* changelog.html

               

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Kohsuke Kawaguchi
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=163628#comment-163628 ]

dogfood commented on JENKINS-13822:
-----------------------------------

Integrated in !http://ci.jenkins-ci.org/images/16x16/blue.png! [jenkins_ui-changes_branch #30|http://ci.jenkins-ci.org/job/jenkins_ui-changes_branch/30/]
     Fixes JENKINS-13822: expand variables in "Root POM" field of Maven plugin (Revision 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0)
changelog entry for [JENKINS-13822] (Revision 25b694351f68076129734604dd270ae48f31b020)

     Result = SUCCESS
ian.kemp : [4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0|https://github.com/jenkinsci/jenkins/commit/4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0]
Files :
* maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
* maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java

Olivier Lamy : [25b694351f68076129734604dd270ae48f31b020|https://github.com/jenkinsci/jenkins/commit/25b694351f68076129734604dd270ae48f31b020]
Files :
* changelog.html

               

> Maven plugin: expand variables in "Room POM" field
> --------------------------------------------------
>
>                 Key: JENKINS-13822
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13822
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: maven
>            Reporter: Ian Kemp
>            Assignee: Kohsuke Kawaguchi
>            Priority: Trivial
>
> The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.
> I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Jesse Glick commented on JENKINS-13822

Maven plugin: expand variables in "Room POM" field

@olamy is 486be07 (fixed in 1.469 I think) related to this?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jesse Glick resolved JENKINS-13822 as Fixed

Maven plugin: expand variables in "Room POM" field

https://github.com/jenkinsci/jenkins/commit/486be0748ad99adb755d5460f742cd58f81f5b88 and https://github.com/jenkinsci/jenkins/commit/9a3f25acbf8c078bd7ecde3330c31dbef9756418 do seem to be part of this.
Change By:	Jesse Glick (08/Nov/12 7:42 PM)
Status:	In Progress Resolved
Resolution:	Fixed

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

Jesse Glick edited a comment on JENKINS-13822

Maven plugin: expand variables in "Room POM" field

https://github.com/jenkinsci/jenkins/commit/486be0748ad99adb755d5460f742cd58f81f5b88 and https://github.com/jenkinsci/jenkins/commit/9a3f25acbf8c078bd7ecde3330c31dbef9756418 (in 1.468) do seem to be part of this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-13822

Maven plugin: expand variables in "Room POM" field

Code changed in jenkins User: Jesse Glick Path: changelog.html maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java http://jenkins-ci.org/commit/jenkins/32748591dc7a38791f0728a56bb7662f0347454e Log: JENKINS-13822 olamy’s 9a3f25a & 25b6943 claimed this fix was in 1.466; actually in 1.467.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jesse Glick assigned JENKINS-13822 to olamy

Maven plugin: expand variables in "Room POM" field

Change By:	Jesse Glick (12/Nov/12 2:53 PM)
Assignee:	Kohsuke Kawaguchi olamy

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

dogfood commented on JENKINS-13822

Maven plugin: expand variables in "Room POM" field

Integrated in jenkins_main_trunk #2063 JENKINS-13822 olamy’s 9a3f25a & 25b6943 claimed this fix was in 1.466; actually in 1.467. (Revision 32748591dc7a38791f0728a56bb7662f0347454e) Result = UNSTABLE Jesse Glick : 32748591dc7a38791f0728a56bb7662f0347454e Files : maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java changelog.html

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira