[JIRA] (JENKINS-13192) groovy template meets error whether there are git changes

Larry Cai created JENKINS-13192:
-----------------------------------

             Summary: groovy template meets error whether there are git changes
                 Key: JENKINS-13192
                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
             Project: Jenkins
          Issue Type: Bug
          Components: email-ext
         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
            Reporter: Larry Cai
            Priority: Minor


groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs

Following varible doesn't recognize inside groovy
- cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
- cs.changeNumber (does it work for cvs or svn ?)

Since I don't know the background and other environment (cvs/svn), I can't provide complete patch

rgs/larry



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Larry Cai updated JENKINS-13192:
--------------------------------

    Summary: groovy template meets error when there are git changes  (was: groovy template meets error whether there are git changes)
   

> groovy template meets error when there are git changes
> ------------------------------------------------------
>
>                 Key: JENKINS-13192
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
>             Project: Jenkins
>          Issue Type: Bug
>          Components: email-ext
>         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
>            Reporter: Larry Cai
>            Priority: Minor
>
> groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs
> Following varible doesn't recognize inside groovy
> - cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
> - cs.changeNumber (does it work for cvs or svn ?)
> Since I don't know the background and other environment (cvs/svn), I can't provide complete patch
> rgs/larry

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160702#comment-160702 ]

Slide-O-Mix commented on JENKINS-13192:
---------------------------------------

The default template is meant more to be an example rather than a fully working version. Please create a template that will work for your exact situation. If you do see specific errors, please feel free to submit a pull request for those.
               

> groovy template meets error when there are git changes
> ------------------------------------------------------
>
>                 Key: JENKINS-13192
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
>             Project: Jenkins
>          Issue Type: Bug
>          Components: email-ext
>         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
>            Reporter: Larry Cai
>            Priority: Minor
>
> groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs
> Following varible doesn't recognize inside groovy
> - cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
> - cs.changeNumber (does it work for cvs or svn ?)
> Since I don't know the background and other environment (cvs/svn), I can't provide complete patch
> rgs/larry

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=161061#comment-161061 ]

Larry Cai commented on JENKINS-13192:
-------------------------------------

Haha, ok, fixed now.

See pull request https://github.com/jenkinsci/email-ext-plugin/pull/36
               

> groovy template meets error when there are git changes
> ------------------------------------------------------
>
>                 Key: JENKINS-13192
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
>             Project: Jenkins
>          Issue Type: Bug
>          Components: email-ext
>         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
>            Reporter: Larry Cai
>            Priority: Minor
>
> groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs
> Following varible doesn't recognize inside groovy
> - cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
> - cs.changeNumber (does it work for cvs or svn ?)
> Since I don't know the background and other environment (cvs/svn), I can't provide complete patch
> rgs/larry

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=161062#comment-161062 ]

SCM/JIRA link daemon commented on JENKINS-13192:
------------------------------------------------

Code changed in jenkins
User: Larry Cai
Path:
 src/main/resources/hudson/plugins/emailext/templates/groovy-html.template
http://jenkins-ci.org/commit/email-ext-plugin/4c16db3144bd23fcacbc3f12ebd8611eddfc9f3c
Log:
  Fix JENKINS-13192

- husdonUser doesn't exist, use author directly
- changeNumber doesn't exist, add check whether the property exist, otherwise show space
- msgAnnotated doesn't exist for it, change to cs

all those parameters need to check in ChangeLogSet or inherited class



               

> groovy template meets error when there are git changes
> ------------------------------------------------------
>
>                 Key: JENKINS-13192
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
>             Project: Jenkins
>          Issue Type: Bug
>          Components: email-ext
>         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
>            Reporter: Larry Cai
>            Priority: Minor
>
> groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs
> Following varible doesn't recognize inside groovy
> - cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
> - cs.changeNumber (does it work for cvs or svn ?)
> Since I don't know the background and other environment (cvs/svn), I can't provide complete patch
> rgs/larry

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=161063#comment-161063 ]

SCM/JIRA link daemon commented on JENKINS-13192:
------------------------------------------------

Code changed in jenkins
User: slide
Path:
 src/main/resources/hudson/plugins/emailext/templates/groovy-html.template
http://jenkins-ci.org/commit/email-ext-plugin/552bd6c80ca85c3b288abf338ef7ce7275e42247
Log:
  Merge pull request #36 from larrycai/master

Bug fix for JENKINS-13192


Compare: https://github.com/jenkinsci/email-ext-plugin/compare/5b20b8e...552bd6c


               

> groovy template meets error when there are git changes
> ------------------------------------------------------
>
>                 Key: JENKINS-13192
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
>             Project: Jenkins
>          Issue Type: Bug
>          Components: email-ext
>         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
>            Reporter: Larry Cai
>            Priority: Minor
>
> groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs
> Following varible doesn't recognize inside groovy
> - cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
> - cs.changeNumber (does it work for cvs or svn ?)
> Since I don't know the background and other environment (cvs/svn), I can't provide complete patch
> rgs/larry

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Slide-O-Mix reassigned JENKINS-13192:
-------------------------------------

    Assignee: Larry Cai

Please close if resolved.
               

> groovy template meets error when there are git changes
> ------------------------------------------------------
>
>                 Key: JENKINS-13192
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
>             Project: Jenkins
>          Issue Type: Bug
>          Components: email-ext
>         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
>            Reporter: Larry Cai
>            Assignee: Larry Cai
>            Priority: Minor
>
> groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs
> Following varible doesn't recognize inside groovy
> - cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
> - cs.changeNumber (does it work for cvs or svn ?)
> Since I don't know the background and other environment (cvs/svn), I can't provide complete patch
> rgs/larry

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Slide-O-Mix resolved JENKINS-13192.
-----------------------------------

    Resolution: Fixed
   

> groovy template meets error when there are git changes
> ------------------------------------------------------
>
>                 Key: JENKINS-13192
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
>             Project: Jenkins
>          Issue Type: Bug
>          Components: email-ext
>         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
>            Reporter: Larry Cai
>            Priority: Minor
>
> groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs
> Following varible doesn't recognize inside groovy
> - cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
> - cs.changeNumber (does it work for cvs or svn ?)
> Since I don't know the background and other environment (cvs/svn), I can't provide complete patch
> rgs/larry

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Larry Cai closed JENKINS-13192.
-------------------------------

   

> groovy template meets error when there are git changes
> ------------------------------------------------------
>
>                 Key: JENKINS-13192
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13192
>             Project: Jenkins
>          Issue Type: Bug
>          Components: email-ext
>         Environment: ubuntu 11.10/openjdk/jenkins1.452/git
>            Reporter: Larry Cai
>            Assignee: Larry Cai
>            Priority: Minor
>
> groovy template had some errors for html/txt report when it has git changes, I didn't check for svn/cvs
> Following varible doesn't recognize inside groovy
> - cs.hudsonUser (no husdonUser for changeSet class, it just error instead of return nil)
> - cs.changeNumber (does it work for cvs or svn ?)
> Since I don't know the background and other environment (cvs/svn), I can't provide complete patch
> rgs/larry

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mark S. reopened JENKINS-13192

groovy template meets error when there are git changes

The text variant of the same template still has that bug.
Change By:	Mark S. (18/Jul/12 8:19 PM)
Resolution:	Fixed
Status:	Closed Reopened

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Slide-O-Mix resolved JENKINS-13192 as Fixed

groovy template meets error when there are git changes

Change By:	Slide-O-Mix (18/Jul/12 9:27 PM)
Status:	Reopened Resolved
Assignee:	Larry Cai Slide-O-Mix
Resolution:	Fixed

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

SCM/JIRA link daemon commented on JENKINS-13192

groovy template meets error when there are git changes

Code changed in jenkins User: slide Path: src/main/resources/hudson/plugins/emailext/templates/groovy-text.template http://jenkins-ci.org/commit/email-ext-plugin/86f5f9e91b839be3b944d9b4a2fd7ceb2c0dfe41 Log: Fix JENKINS-13192 for text template Fixed the author issue for the text template as well.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira