Jenkins › Jenkins issues

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

Classic

List

Threaded

16 messages Options

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

Eyal Edri created JENKINS-12972:
-----------------------------------

Summary: Add option to run 'git bisect' to find which commit added new bugs
Key: JENKINS-12972
URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
Project: Jenkins
Issue Type: New Feature
Components: findbugs
Reporter: Eyal Edri
Assignee: Ulli Hafner
Priority: Minor

Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
It becomes especially difficult to know when a high volume of commits is pushed at once.

find-bugs plug-in could have a new option to tick in the 'advanced section',
which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.

that would simply and automate the process of finding who wrote the bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159832#comment-159832 ]

Ulli Hafner commented on JENKINS-12972:
---------------------------------------

Wouldn't such a feature make more sense in an extra plug-in? I think this feature should be available to every item that changes the build status. I.e., failing tests, new compiler warnings, new findbugs warnings, etc. Moreover (since this is only available with git), it should be an extension to the git plug-in.

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: findbugs
> Reporter: Eyal Edri
> Assignee: Ulli Hafner
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ulli Hafner updated JENKINS-12972:
----------------------------------

Component/s: git

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Assignee: Ulli Hafner
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Assignee: Ulli Hafner
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159834#comment-159834 ]

Eyal Edri commented on JENKINS-12972:
-------------------------------------

Not sure i understand what 'extra plugin' is, but i agree it can be useful for other plugins as well.
you mean adding an extension point to git plugin (like gerrit-trigger)?

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Assignee: Ulli Hafner
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159832#comment-159832 ]

Ulli Hafner edited comment on JENKINS-12972 at 3/5/12 10:00 AM:
----------------------------------------------------------------

Wouldn't such a feature make more sense in an additional plug-in? I think this feature should be available to every item that changes the build status. I.e., failing tests, new compiler warnings, new findbugs warnings, etc. Moreover (since this is only available with git), it should be an extension to the git plug-in.

was (Author: drulli):
Wouldn't such a feature make more sense in an extra plug-in? I think this feature should be available to every item that changes the build status. I.e., failing tests, new compiler warnings, new findbugs warnings, etc. Moreover (since this is only available with git), it should be an extension to the git plug-in.

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Assignee: Ulli Hafner
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159836#comment-159836 ]

Ulli Hafner commented on JENKINS-12972:
---------------------------------------

I think the best approach would be to have a new plug-in that provides an extension point so that other plug-ins like the findbugs plug-in can register. This new plug-in has the knowledge on how to do the git bisect. And this plug-in needs to get an event from the findbugs plug-in (and all other participating plug-ins), when the build status has been changed.

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Assignee: Ulli Hafner
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162422#comment-162422 ]

Rob van Oostrum commented on JENKINS-12972:
-------------------------------------------

Wouldn't bisect require multiple subsequent build runs (or in this specific use case: multiple find-bugs runs) as it bisects towards the commit that introduces the breakage? These runs shouldn't really count as "builds", and shouldn't show up as such in the build history/statistics of the job. So one of the (presumably) big pieces of work in core would be to let Jenkins execute builds "quietly" while still being able to process the results.

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162423#comment-162423 ]

Eyal Edri commented on JENKINS-12972:
-------------------------------------

So maybe 'git bisect' isn't the right approach?
findbugs knows where the bug is (which class/what line), so i assume it can compare between the code diff from each git commit and his findbugs report and show a "suspected commit" that introduced the breakage.

i assume this will be relevant to any other plugin (pmd,checkstyle,etc...).

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162424#comment-162424 ]

Rob van Oostrum commented on JENKINS-12972:
-------------------------------------------

Probably makes more sense to work off 'git blame' instead: http://linux.die.net/man/1/git-blame

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

[ https://issues.jenkins-ci.org/browse/JENKINS-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162893#comment-162893 ]

bnovc commented on JENKINS-12972:
---------------------------------

{{git blame}} would be faster, but you would often not get correct results. This only works if the problem you're trying to detect was caused by the last edit to the line the problem was exposed.

I would really like to see {{git bisect}} offered as part of a normal build with the git plugin. That way I would immediately know who broke the build definitively. This would save significant time in triaging, as the person responsible could be notified automatically.

> Add option to run 'git bisect' to find which commit added new bugs
> -------------------------------------------------------------------
>
> Key: JENKINS-12972
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12972
> Project: Jenkins
> Issue Type: New Feature
> Components: analysis-core, core, findbugs, git
> Reporter: Eyal Edri
> Priority: Minor
>
> Today, when you run find-bugs plug-in triggered by a git commit, you can't know exactly which commit added those bugs.
> It becomes especially difficult to know when a high volume of commits is pushed at once.
> find-bugs plug-in could have a new option to tick in the 'advanced section',
> which will do a 'git bisect' on the git commits that caused a new bug and display/email to commiter who did it.
> that would simply and automate the process of finding who wrote the bug.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

Anyone thought about working on this? Right now, our Jenkins emails out all sorts of emails about things breaking or being fixed, but doesn't pin-point the person who should fix breakages. Finding the responsible party seems more important than the "minor" on this issue.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

Hi everyone. I need this bug/feature so much that I'm willing to pay for it.
This offer is registered at FreedomSponsors (http://www.freedomsponsors.org/core/issue/33/add-option-to-run-git-bisect-to-find-which-commit-added-new-bugs).
Once you solve it (according to the acceptance criteria described there), just create a FreedomSponsors account and mark it as resolved (oh, you'll need a Paypal account too)
I'll then check it out and will gladly pay up!

If anyone else would like to throw in a few bucks to elevate the priority on this issue, you should check out FreedomSponsors!

I will try to get my employers to kick in more money.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

I would love this feature. Now I am running bisect manually. It would be great that jenkins could tell which commit broke compilation or unit test.

JIRA noreply@jenkins-ci.org

[JIRA] (JENKINS-12972) Add option to run 'git bisect' to find which commit added new bugs

In reply to this post by JIRA noreply@jenkins-ci.org

I would love this feature. Now I am running bisect manually. It would be great that jenkins could tell which single commit broke compilation or unit test.