[JIRA] (JENKINS-12908) TFS errors during get operation do not fail the build

jeffolson created JENKINS-12908:
-----------------------------------

             Summary: TFS errors during get operation do not fail the build
                 Key: JENKINS-12908
                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12908
             Project: Jenkins
          Issue Type: Bug
          Components: tfs
    Affects Versions: current
         Environment: Windows XP
            Reporter: jeffolson
            Assignee: redsolo


We had a build that got several TFS errors when getting the full set of latest code (due to moving to a new Jenkins machine).  However, these errors did not cause the build to fail.  This is troubling, as the files in question were not downloaded (or in some cases were left writable, meaning that subsequent builds failed).  It seems like the plugin should fail the build anytime an error occurs when getting code.  

Here are the errors we got.  I'm sure there are other possible errors one could get, too.


---- Summary: 0 conflicts, 0 warnings, 6 errors ----
F:\Hudson\jobs\checkpoint\workspace\CPWar\src\com\tta\checkpoint\servlet\CPHelpService.java: The server returned content type text/html, which is not supported.
F:\Hudson\jobs\checkpoint\workspace\CPWar\src\com\tta\checkpoint\servlet\CPToolItemServlet.java: TF246017: Team Foundation Server could not connect to the database. Verify that the server that is hosting the database is operational, and that network problems are not blocking communication with the server.
F:\Hudson\jobs\checkpoint\workspace\CPWar\src\com\tta\checkpoint\uiData\CPCodificationItem.java: TF246017: Team Foundation Server could not connect to the database. Verify that the server that is hosting the database is operational, and that network problems are not blocking communication with the server.
F:\Hudson\jobs\checkpoint\workspace\CPWar\src\com\tta\checkpoint\utils\CPQueueWriter.java: TF246017: Team Foundation Server could not connect to the database. Verify that the server that is hosting the database is operational, and that network problems are not blocking communication with the server.
F:\Hudson\jobs\checkpoint\workspace\CPWar\web\basic\secCompForm.jsp: TF246017: Team Foundation Server could not connect to the database. Verify that the server that is hosting the database is operational, and that network problems are not blocking communication with the server.
F:\Hudson\jobs\checkpoint\workspace\CPWar\web\basic\css\srchAdvQry.css: The server returned content type text/html, which is not supported.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

redsolo commented on JENKINS-12908

TFS errors during get operation do not fail the build

What kind of problems did it miss? If I have the incorrect server/auth then it will fail the build. But i guess there could be a problem with the TFS workspace if it has been moved to a new server...

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

jeffolson commented on JENKINS-12908

TFS errors during get operation do not fail the build

Hi Erik, The specific errors are in the initial description. In this case they were all either "TF246017: Team Foundation Server could not connect to the database" errors, or "The server returned content type text/html, which is not supported." errors. Thanks, Jeff

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

redsolo commented on JENKINS-12908

TFS errors during get operation do not fail the build

The code behind the execution of the TFS command line will check if the tf tool returns with 1 or 0, and those are marked as success. My guess is that the tf command line tool returned either 1 or 0 regardless of the errors. That makes it somewhat difficult for the jenkins plugin to know if there was a problem or not. If the authentication fails, then tf returns with the code 100 and thus the plugin fails the build. I reccon I could do some parsing of the console output that the TFS tool generates and fail the build if it finds anything resembling such a problem. But that would not be possible for the history command, because if someone checks in a comment resembling the text the plugin will look for then the plugin would fail the build for no good reason. Does this happen a lot for you?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

jeffolson commented on JENKINS-12908

TFS errors during get operation do not fail the build

Thanks, Erik. No, this is very infrequent, thankfully. It sounds like this probably can't be fixed, then, so you can close this issue. Thanks for investigating it! Jeff

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira