[JIRA] (JENKINS-12841) EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly

mwebber created JENKINS-12841:
---------------------------------

             Summary: EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
                 Key: JENKINS-12841
                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
             Project: Jenkins
          Issue Type: Bug
          Components: envinject
            Reporter: mwebber
            Assignee: gbois
            Priority: Critical


This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.

I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
materialize_workspace_path=${WORKSPACE}/materialize_workspace

In 1.25, this environment variable was correctly given the value
{{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

In 1.26, this environment variable was WRONGLY given the value
{{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159365#comment-159365 ]

gbois commented on JENKINS-12841:
---------------------------------

Could you check that your job has run on master or on a slave?
               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159367#comment-159367 ]

mwebber commented on JENKINS-12841:
-----------------------------------

The job with the problem ran on a slave. It has a custom workspace.
               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159375#comment-159375 ]

gbois commented on JENKINS-12841:
---------------------------------

I can't reproduce.
Could you check again the problem persists?

And could you attach your job conifguration file (config.xml in $JENKINS_HOME/jobs/<your_job>)?
               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on JENKINS-12841 started by gbois.

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

mwebber updated JENKINS-12841:
------------------------------

    Attachment: config.xml

Uploaded config.xml for the job that had the problem
               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>         Attachments: config.xml
>
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159382#comment-159382 ]

mwebber commented on JENKINS-12841:
-----------------------------------

>> Could you check again the problem persists?

Let me know if you still need this. I don't have a suitable test Jenkins environment to do this in, so although I can do it if really necessary, it will be somewhat disruptive, so I'm somewhat reluctant.

If it helps, I'm quite sure that the problem was introduced in 1.26.


               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>         Attachments: config.xml
>
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159401#comment-159401 ]

SCM/JIRA link daemon commented on JENKINS-12841:
------------------------------------------------

Code changed in jenkins
User: Gregory Boissinot
Path:
 src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
 src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
http://jenkins-ci.org/commit/envinject-plugin/b2c132e077b2bb052df175660a8906533d681d37
Log:
  Fix JENKINS-12704 and JENKINS-12841


Compare: https://github.com/jenkinsci/envinject-plugin/compare/6ff47b2...b2c132e


               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>         Attachments: config.xml
>
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159408#comment-159408 ]

gbois commented on JENKINS-12841:
---------------------------------

Could you test with envinject 1.28?
               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>         Attachments: config.xml
>
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159414#comment-159414 ]

mwebber commented on JENKINS-12841:
-----------------------------------

The problem is fixed in 1.28 - thanks for your prompt attention.
Should a test be added for this case - we've had a couple of releases lately which have broken stuff.
               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>         Attachments: config.xml
>
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159535#comment-159535 ]

SCM/JIRA link daemon commented on JENKINS-12841:
------------------------------------------------

Code changed in jenkins
User: Gregory Boissinot
Path:
 src/test/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapperTest.java
http://jenkins-ci.org/commit/envinject-plugin/eb3cb491dcede8409b26bc8fe3cfc1e0af99b1d9
Log:
  Add an integration test to fix JENKINS-12841



               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>         Attachments: config.xml
>
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159536#comment-159536 ]

SCM/JIRA link daemon commented on JENKINS-12841:
------------------------------------------------

Code changed in jenkins
User: Gregory Boissinot
Path:
 src/test/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapperTest.java
http://jenkins-ci.org/commit/envinject-plugin/6fd8c4018572af8c7154cab49c7552da831f96f1
Log:
  Add an integration test to fix JENKINS-12841


Compare: https://github.com/jenkinsci/envinject-plugin/compare/db8e61f...6fd8c40


               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>         Attachments: config.xml
>
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

gbois resolved JENKINS-12841.
-----------------------------

    Resolution: Fixed

Test added
               

> EnvInject Plugin 1.26 does not substitute ${WORKSPACE} correctly
> ----------------------------------------------------------------
>
>                 Key: JENKINS-12841
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12841
>             Project: Jenkins
>          Issue Type: Bug
>          Components: envinject
>            Reporter: mwebber
>            Assignee: gbois
>            Priority: Critical
>         Attachments: config.xml
>
>
> This problem appeared when I upgraded the EnvInject Plugin from 1.25 to 1.26, so the problem was probably introduced with the fix for JENKINS-12704.
> I have a job with "Inject environment variables to the build process" selected, and the following line in "Properties Content":
> materialize_workspace_path=${WORKSPACE}/materialize_workspace
> In 1.25, this environment variable was correctly given the value
> {{/scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}
> In 1.26, this environment variable was WRONGLY given the value
> {{/scratch/jenkins_slave//scratch/jenkins_workspace/GDA_master.tests.RH5_64/materialize_workspace}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira