[JIRA] (JENKINS-12748) Scriptler remote catalog breaks when script name contains certain characters

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12748) Scriptler remote catalog breaks when script name contains certain characters

JIRA noreply@jenkins-ci.org
abayer created JENKINS-12748:
--------------------------------

             Summary: Scriptler remote catalog breaks when script name contains certain characters
                 Key: JENKINS-12748
                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12748
             Project: Jenkins
          Issue Type: Bug
          Components: scriptler
            Reporter: abayer
            Assignee: domi


The scriptler remote catalog breaks when trying to get a script with a "/" in its metadata name. e.g., for "Disable/Enable Jobs Matching Pattern", you get http://localhost:8080/scriptler/downloadScript?id=disableEnableJobsMatchingPattern.groovy&name=Disable/Enable%20Jobs%20Matching%20Pattern&catalog=gh, with Scriptler trying to put the "/" in the output filename.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12748) Scriptler remote catalog breaks when script name contains certain characters

JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-12748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159223#comment-159223 ]

SCM/JIRA link daemon commented on JENKINS-12748:
------------------------------------------------

Code changed in jenkins
User: imod
Path:
 src/main/java/org/jenkinsci/plugins/scriptler/ScriptlerManagment.java
 src/main/java/org/jenkinsci/plugins/scriptler/ScritplerPluginImpl.java
 src/main/java/org/jenkinsci/plugins/scriptler/config/NamedResource.java
 src/main/java/org/jenkinsci/plugins/scriptler/config/Script.java
 src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptSet.java
 src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfiguration.java
 src/main/java/org/jenkinsci/plugins/scriptler/util/ByIdSorter.java
 src/main/java/org/jenkinsci/plugins/scriptler/util/ByNameSorter.java
 src/main/java/org/jenkinsci/plugins/scriptler/util/ScriptHelper.java
 src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/catalog.jelly
 src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.jelly
 src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.properties
 src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/index.jelly
 src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/runscript.jelly
 src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/scriptsettings.jelly
http://jenkins-ci.org/commit/scriptler-plugin/37223a7490c0bad7e839ad8d2720627e30d3ee79
Log:
  [FIXED JENKINS-12748] differentiate between name and id





               

> Scriptler remote catalog breaks when script name contains certain characters
> ----------------------------------------------------------------------------
>
>                 Key: JENKINS-12748
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12748
>             Project: Jenkins
>          Issue Type: Bug
>          Components: scriptler
>            Reporter: abayer
>            Assignee: domi
>
> The scriptler remote catalog breaks when trying to get a script with a "/" in its metadata name. e.g., for "Disable/Enable Jobs Matching Pattern", you get http://localhost:8080/scriptler/downloadScript?id=disableEnableJobsMatchingPattern.groovy&name=Disable/Enable%20Jobs%20Matching%20Pattern&catalog=gh, with Scriptler trying to put the "/" in the output filename.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12748) Scriptler remote catalog breaks when script name contains certain characters

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

     [ https://issues.jenkins-ci.org/browse/JENKINS-12748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

SCM/JIRA link daemon resolved JENKINS-12748.
--------------------------------------------

    Resolution: Fixed
   

> Scriptler remote catalog breaks when script name contains certain characters
> ----------------------------------------------------------------------------
>
>                 Key: JENKINS-12748
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12748
>             Project: Jenkins
>          Issue Type: Bug
>          Components: scriptler
>            Reporter: abayer
>            Assignee: domi
>
> The scriptler remote catalog breaks when trying to get a script with a "/" in its metadata name. e.g., for "Disable/Enable Jobs Matching Pattern", you get http://localhost:8080/scriptler/downloadScript?id=disableEnableJobsMatchingPattern.groovy&name=Disable/Enable%20Jobs%20Matching%20Pattern&catalog=gh, with Scriptler trying to put the "/" in the output filename.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12748) Scriptler remote catalog breaks when script name contains certain characters

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-12748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159224#comment-159224 ]

dogfood commented on JENKINS-12748:
-----------------------------------

Integrated in !http://ci.jenkins-ci.org/images/16x16/blue.png! [plugins_scriptler #40|http://ci.jenkins-ci.org/job/plugins_scriptler/40/]
     [FIXED JENKINS-12748] differentiate between name and id (Revision 37223a7490c0bad7e839ad8d2720627e30d3ee79)

     Result = SUCCESS
imod :
Files :
* src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfiguration.java
* src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.jelly
* src/main/java/org/jenkinsci/plugins/scriptler/util/ScriptHelper.java
* src/main/java/org/jenkinsci/plugins/scriptler/util/ByNameSorter.java
* src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/catalog.jelly
* src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/scriptsettings.jelly
* src/main/java/org/jenkinsci/plugins/scriptler/config/Script.java
* src/main/java/org/jenkinsci/plugins/scriptler/ScriptlerManagment.java
* src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.properties
* src/main/java/org/jenkinsci/plugins/scriptler/util/ByIdSorter.java
* src/main/java/org/jenkinsci/plugins/scriptler/config/NamedResource.java
* src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/index.jelly
* src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptSet.java
* src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/runscript.jelly
* src/main/java/org/jenkinsci/plugins/scriptler/ScritplerPluginImpl.java

               

> Scriptler remote catalog breaks when script name contains certain characters
> ----------------------------------------------------------------------------
>
>                 Key: JENKINS-12748
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12748
>             Project: Jenkins
>          Issue Type: Bug
>          Components: scriptler
>            Reporter: abayer
>            Assignee: domi
>
> The scriptler remote catalog breaks when trying to get a script with a "/" in its metadata name. e.g., for "Disable/Enable Jobs Matching Pattern", you get http://localhost:8080/scriptler/downloadScript?id=disableEnableJobsMatchingPattern.groovy&name=Disable/Enable%20Jobs%20Matching%20Pattern&catalog=gh, with Scriptler trying to put the "/" in the output filename.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12748) Scriptler remote catalog breaks when script name contains certain characters

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-12748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159363#comment-159363 ]

domi commented on JENKINS-12748:
--------------------------------

fixed in 2.1
               

> Scriptler remote catalog breaks when script name contains certain characters
> ----------------------------------------------------------------------------
>
>                 Key: JENKINS-12748
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12748
>             Project: Jenkins
>          Issue Type: Bug
>          Components: scriptler
>            Reporter: abayer
>            Assignee: domi
>
> The scriptler remote catalog breaks when trying to get a script with a "/" in its metadata name. e.g., for "Disable/Enable Jobs Matching Pattern", you get http://localhost:8080/scriptler/downloadScript?id=disableEnableJobsMatchingPattern.groovy&name=Disable/Enable%20Jobs%20Matching%20Pattern&catalog=gh, with Scriptler trying to put the "/" in the output filename.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Loading...