[JIRA] (JENKINS-12502) Password with consecutive dollar characters not masked

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12502) Password with consecutive dollar characters not masked

JIRA noreply@jenkins-ci.org
Hiren Patel created JENKINS-12502:
-------------------------------------

             Summary: Password with consecutive dollar characters not masked
                 Key: JENKINS-12502
                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12502
             Project: Jenkins
          Issue Type: Bug
          Components: mask-passwords
            Reporter: Hiren Patel
            Assignee: Romain Seguy


When trying to mask passwords with 2 or more dollar ($) characters together, the password is not masked
e.g. {{pa$$word}} is not masked

Also, the console log shows this with only one dollar character
e.g. if you add a window batch command:
bq. {{echo %PASSWORD%}}
with {{pa$$word}} as {{%PASSWORD%}} the console will show:
{quote}
{{D:\jenkins\workspace\hp_test_job>echo pa$word}}
{{pa$word}}
{quote}
notice only one dollar in output ... is $ an escape character?


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12502) Password with consecutive dollar characters not masked

JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158099#comment-158099 ]

Romain Seguy commented on JENKINS-12502:
----------------------------------------

I confirm.
I'm investigating.
               

> Password with consecutive dollar characters not masked
> ------------------------------------------------------
>
>                 Key: JENKINS-12502
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12502
>             Project: Jenkins
>          Issue Type: Bug
>          Components: mask-passwords
>            Reporter: Hiren Patel
>            Assignee: Romain Seguy
>
> When trying to mask passwords with 2 or more dollar ($) characters together, the password is not masked
> e.g. {{pa$$word}} is not masked
> Also, the console log shows this with only one dollar character
> e.g. if you add a window batch command:
> bq. {{echo %PASSWORD%}}
> with {{pa$$word}} as {{%PASSWORD%}} the console will show:
> {quote}
> {{D:\jenkins\workspace\hp_test_job>echo pa$word}}
> {{pa$word}}
> {quote}
> notice only one dollar in output ... is $ an escape character?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12502) Password with consecutive dollar characters not masked

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158239#comment-158239 ]

Romain Seguy commented on JENKINS-12502:
----------------------------------------

So, the issue doesn't come actually from the plugin but from Jenkins: If you use a plain Jenkins install with no plugin, define a build parameter whose value is pa$$word, and display it in a build step, the output will be pa$word. I'm checking why.
               

> Password with consecutive dollar characters not masked
> ------------------------------------------------------
>
>                 Key: JENKINS-12502
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12502
>             Project: Jenkins
>          Issue Type: Bug
>          Components: mask-passwords
>            Reporter: Hiren Patel
>            Assignee: Romain Seguy
>
> When trying to mask passwords with 2 or more dollar ($) characters together, the password is not masked
> e.g. {{pa$$word}} is not masked
> Also, the console log shows this with only one dollar character
> e.g. if you add a window batch command:
> bq. {{echo %PASSWORD%}}
> with {{pa$$word}} as {{%PASSWORD%}} the console will show:
> {quote}
> {{D:\jenkins\workspace\hp_test_job>echo pa$word}}
> {{pa$word}}
> {quote}
> notice only one dollar in output ... is $ an escape character?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12502) Variable with consecutive dollar characters not displayed as expected: One doller char is dropped

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

     [ https://issues.jenkins-ci.org/browse/JENKINS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Romain Seguy updated JENKINS-12502:
-----------------------------------

    Summary: Variable with consecutive dollar characters not displayed as expected: One doller char is dropped  (was: Password with consecutive dollar characters not masked)
   

> Variable with consecutive dollar characters not displayed as expected: One doller char is dropped
> -------------------------------------------------------------------------------------------------
>
>                 Key: JENKINS-12502
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12502
>             Project: Jenkins
>          Issue Type: Bug
>          Components: mask-passwords
>            Reporter: Hiren Patel
>            Assignee: Romain Seguy
>
> When trying to mask passwords with 2 or more dollar ($) characters together, the password is not masked
> e.g. {{pa$$word}} is not masked
> Also, the console log shows this with only one dollar character
> e.g. if you add a window batch command:
> bq. {{echo %PASSWORD%}}
> with {{pa$$word}} as {{%PASSWORD%}} the console will show:
> {quote}
> {{D:\jenkins\workspace\hp_test_job>echo pa$word}}
> {{pa$word}}
> {quote}
> notice only one dollar in output ... is $ an escape character?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12502) Variable with consecutive dollar characters not displayed as expected: One doller char is dropped

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158242#comment-158242 ]

Hiren Patel commented on JENKINS-12502:
---------------------------------------

ah right, I think you can use $ to reference another parameter
e.g. if you have a parameter called {{PARAM1}} defined as {{world}}
and another parameter {{PARAM2}} defined as {{hello$PARAM1}}
{{PARAM2}} will be expanded to {{helloworld}}
However, I've not seen use documented, so don't know if it an actual feature (and I don't know if it works everywhere). Plus I didn't expect to be able to reference environment variable like this on windows


               

> Variable with consecutive dollar characters not displayed as expected: One doller char is dropped
> -------------------------------------------------------------------------------------------------
>
>                 Key: JENKINS-12502
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12502
>             Project: Jenkins
>          Issue Type: Bug
>          Components: mask-passwords
>            Reporter: Hiren Patel
>            Assignee: Romain Seguy
>
> When trying to mask passwords with 2 or more dollar ($) characters together, the password is not masked
> e.g. {{pa$$word}} is not masked
> Also, the console log shows this with only one dollar character
> e.g. if you add a window batch command:
> bq. {{echo %PASSWORD%}}
> with {{pa$$word}} as {{%PASSWORD%}} the console will show:
> {quote}
> {{D:\jenkins\workspace\hp_test_job>echo pa$word}}
> {{pa$word}}
> {quote}
> notice only one dollar in output ... is $ an escape character?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12502) Variable with consecutive dollar characters not displayed as expected: One doller char is dropped

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158242#comment-158242 ]

Hiren Patel edited comment on JENKINS-12502 at 1/27/12 4:37 PM:
----------------------------------------------------------------

ah right, I think you can use $ to reference another parameter
e.g. if you have a parameter called {{PARAM1}} defined as {{world}}
and another parameter {{PARAM2}} defined as {{hello$PARAM1}}
{{PARAM2}} will be expanded to {{helloworld}}
However, I've not seen this documented, so don't know if it is an actual feature (and I don't know if it works everywhere). Plus I didn't expect to be able to reference environment variables like this on windows


               
      was (Author: hiren):
    ah right, I think you can use $ to reference another parameter
e.g. if you have a parameter called {{PARAM1}} defined as {{world}}
and another parameter {{PARAM2}} defined as {{hello$PARAM1}}
{{PARAM2}} will be expanded to {{helloworld}}
However, I've not seen use documented, so don't know if it an actual feature (and I don't know if it works everywhere). Plus I didn't expect to be able to reference environment variable like this on windows


                 

> Variable with consecutive dollar characters not displayed as expected: One doller char is dropped
> -------------------------------------------------------------------------------------------------
>
>                 Key: JENKINS-12502
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12502
>             Project: Jenkins
>          Issue Type: Bug
>          Components: mask-passwords
>            Reporter: Hiren Patel
>            Assignee: Romain Seguy
>
> When trying to mask passwords with 2 or more dollar ($) characters together, the password is not masked
> e.g. {{pa$$word}} is not masked
> Also, the console log shows this with only one dollar character
> e.g. if you add a window batch command:
> bq. {{echo %PASSWORD%}}
> with {{pa$$word}} as {{%PASSWORD%}} the console will show:
> {quote}
> {{D:\jenkins\workspace\hp_test_job>echo pa$word}}
> {{pa$word}}
> {quote}
> notice only one dollar in output ... is $ an escape character?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-12502) Variable with consecutive dollar characters not displayed as expected: One doller char is dropped

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

     [ https://issues.jenkins-ci.org/browse/JENKINS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Romain Seguy reassigned JENKINS-12502:
--------------------------------------

    Assignee: Daniel Petisme  (was: Romain Seguy)
   

> Variable with consecutive dollar characters not displayed as expected: One doller char is dropped
> -------------------------------------------------------------------------------------------------
>
>                 Key: JENKINS-12502
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12502
>             Project: Jenkins
>          Issue Type: Bug
>          Components: mask-passwords
>            Reporter: Hiren Patel
>            Assignee: Daniel Petisme
>
> When trying to mask passwords with 2 or more dollar ($) characters together, the password is not masked
> e.g. {{pa$$word}} is not masked
> Also, the console log shows this with only one dollar character
> e.g. if you add a window batch command:
> bq. {{echo %PASSWORD%}}
> with {{pa$$word}} as {{%PASSWORD%}} the console will show:
> {quote}
> {{D:\jenkins\workspace\hp_test_job>echo pa$word}}
> {{pa$word}}
> {quote}
> notice only one dollar in output ... is $ an escape character?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Loading...