[JIRA] (JENKINS-11953) EC2 plugin needs to load regions dynamically

Ruben Orduz created JENKINS-11953:
-------------------------------------

             Summary: EC2 plugin needs to load regions dynamically
                 Key: JENKINS-11953
                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
             Project: Jenkins
          Issue Type: Bug
          Components: ec2
         Environment: Win/Linux
            Reporter: Ruben Orduz
            Assignee: Kohsuke Kawaguchi
            Priority: Minor


EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruben Orduz updated JENKINS-11953:
----------------------------------

       Priority: Major  (was: Minor)
    Description:
EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.

The problem code can be seen here:

https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

  was:EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.

   

> EC2 plugin needs to load regions dynamically
> --------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: Kohsuke Kawaguchi
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=156216#comment-156216 ]

Ruben Orduz commented on JENKINS-11953:
---------------------------------------

While not fixing the root cause (i.e. dynamic region loading from API call), I added the coded/config changes to add the new Oregon region. You can find these at:
https://gist.github.com/1423702
               

> EC2 plugin needs to load regions dynamically
> --------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: Kohsuke Kawaguchi
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruben Orduz updated JENKINS-11953:
----------------------------------

    Summary: EC2 plugin needs to load regions dynamically (or add Oregon region to list)  (was: EC2 plugin needs to load regions dynamically)
   

> EC2 plugin needs to load regions dynamically (or add Oregon region to list)
> ---------------------------------------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: Kohsuke Kawaguchi
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille reassigned JENKINS-11953:
-------------------------------------

    Assignee: Frank Bille  (was: Kohsuke Kawaguchi)
   

> EC2 plugin needs to load regions dynamically (or add Oregon region to list)
> ---------------------------------------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: Frank Bille
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on JENKINS-11953 started by Kohsuke Kawaguchi.

> EC2 plugin needs to load regions dynamically (or add Oregon region to list)
> ---------------------------------------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: Kohsuke Kawaguchi
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158491#comment-158491 ]

Frank Bille commented on JENKINS-11953:
---------------------------------------

This has been fixed on master, and will part of the next release

https://github.com/jenkinsci/ec2-plugin/commit/c26a52ce583e4b5ea1be9fc52933c52c5e5e3dd1
               

> EC2 plugin needs to load regions dynamically (or add Oregon region to list)
> ---------------------------------------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: Frank Bille
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159394#comment-159394 ]

SCM/JIRA link daemon commented on JENKINS-11953:
------------------------------------------------

Code changed in jenkins
User: Francis Upton IV
Path:
 src/main/java/hudson/plugins/ec2/AmazonEC2Cloud.java
 src/main/java/hudson/plugins/ec2/AwsRegion.java
 src/main/java/hudson/plugins/ec2/EC2Cloud.java
 src/main/java/hudson/plugins/ec2/EC2Computer.java
 src/main/java/hudson/plugins/ec2/EC2Slave.java
 src/main/java/hudson/plugins/ec2/PluginImpl.java
 src/main/java/hudson/plugins/ec2/SlaveTemplate.java
 src/main/resources/hudson/plugins/ec2/AmazonEC2Cloud/config-entries.jelly
 src/main/resources/hudson/plugins/ec2/EC2Computer/configure.jelly
 src/main/resources/hudson/plugins/ec2/EC2Slave/help-zone.html
 src/main/resources/hudson/plugins/ec2/Messages.properties
 src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly
 src/test/java/hudson/plugins/ec2/AmazonEC2CloudTest.java
 src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java
 src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java
http://jenkins-ci.org/commit/ec2-plugin/f0e542fa9b2c6e4f112294b92145afd4e04eadd9
Log:
  [FIXED JENKINS-8946] Option to set Zone as well as region for instance creation [FIXED JENKINS-11953] Dynamically local AWS regions


Compare: https://github.com/jenkinsci/ec2-plugin/compare/19c419b...f0e542f


               

> EC2 plugin needs to load regions dynamically (or add Oregon region to list)
> ---------------------------------------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: Frank Bille
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

francis Upton resolved JENKINS-11953.
-------------------------------------

      Assignee: francis Upton  (was: Frank Bille)
    Resolution: Fixed

Fixed in 1.15
               

> EC2 plugin needs to load regions dynamically (or add Oregon region to list)
> ---------------------------------------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: francis Upton
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://issues.jenkins-ci.org/browse/JENKINS-11953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159396#comment-159396 ]

dogfood commented on JENKINS-11953:
-----------------------------------

Integrated in !http://ci.jenkins-ci.org/images/16x16/blue.png! [plugins_ec2 #60|http://ci.jenkins-ci.org/job/plugins_ec2/60/]
     [FIXED JENKINS-8946] Option to set Zone as well as region for instance creation [FIXED JENKINS-11953] Dynamically local AWS regions (Revision f0e542fa9b2c6e4f112294b92145afd4e04eadd9)

     Result = SUCCESS
francis :
Files :
* src/main/java/hudson/plugins/ec2/AmazonEC2Cloud.java
* src/main/java/hudson/plugins/ec2/EC2Slave.java
* src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java
* src/main/java/hudson/plugins/ec2/SlaveTemplate.java
* src/main/resources/hudson/plugins/ec2/EC2Slave/help-zone.html
* src/main/resources/hudson/plugins/ec2/AmazonEC2Cloud/config-entries.jelly
* src/main/java/hudson/plugins/ec2/AwsRegion.java
* src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly
* src/main/java/hudson/plugins/ec2/EC2Computer.java
* src/main/resources/hudson/plugins/ec2/Messages.properties
* src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java
* src/main/resources/hudson/plugins/ec2/EC2Computer/configure.jelly
* src/test/java/hudson/plugins/ec2/AmazonEC2CloudTest.java
* src/main/java/hudson/plugins/ec2/EC2Cloud.java
* src/main/java/hudson/plugins/ec2/PluginImpl.java

               

> EC2 plugin needs to load regions dynamically (or add Oregon region to list)
> ---------------------------------------------------------------------------
>
>                 Key: JENKINS-11953
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11953
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>         Environment: Win/Linux
>            Reporter: Ruben Orduz
>            Assignee: francis Upton
>
> EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.
> The problem code can be seen here:
> https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira