|
Allowing same type of parameter for triggered build more than once seems redundant
---------------------------------------------------------------------------------- Key: JENKINS-8916 URL: http://issues.jenkins-ci.org/browse/JENKINS-8916 Project: Jenkins Issue Type: Bug Components: parameterized-trigger Affects Versions: current Reporter: Fred G Assignee: huybrechts Priority: Minor While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. The only type where it might make sense is "Parameters from properties file". I think for every type of parameters a simple checkbox is sufficient. I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
[ http://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146379#comment-146379 ] Fred G commented on JENKINS-8916: --------------------------------- I'm trying to replace the following jelly script in BuildTriggerConfig/config.jelly: {code} <f:hetero-list name="configs" hasHeader="true" descriptors="${descriptor.getBuilderConfigDescriptors()}" items="${instance.configs}" addCaption="${%Add Parameters}" /> {code} with something like {code} <f:descriptorList descriptors="${descriptor.getBuilderConfigDescriptors()}" instances="${instance.configs}"/> {code} It looks ok, but unfortunately does not save which type of parameter was selected (checked). Could you give me hint what I need to do to get it working? Is there any other jelly tag that deals with a list and displays checkboxes? (I noticed that <f:hetero-radio/> exists, but unfortunately it allows only radio buttons.) Best Regards, Fred > Allowing same type of parameter for triggered build more than once seems redundant > ---------------------------------------------------------------------------------- > > Key: JENKINS-8916 > URL: http://issues.jenkins-ci.org/browse/JENKINS-8916 > Project: Jenkins > Issue Type: Bug > Components: parameterized-trigger > Affects Versions: current > Reporter: Fred G > Assignee: Fred G > Priority: Minor > > While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. > For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. > The only type where it might make sense is "Parameters from properties file". > I think for every type of parameters a simple checkbox is sufficient. > I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by JIRA noreply@jenkins-ci.org
[ http://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred G reassigned JENKINS-8916: ------------------------------- Assignee: huybrechts (was: Fred G) > Allowing same type of parameter for triggered build more than once seems redundant > ---------------------------------------------------------------------------------- > > Key: JENKINS-8916 > URL: http://issues.jenkins-ci.org/browse/JENKINS-8916 > Project: Jenkins > Issue Type: Bug > Components: parameterized-trigger > Affects Versions: current > Reporter: Fred G > Assignee: huybrechts > Priority: Minor > > While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. > For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. > The only type where it might make sense is "Parameters from properties file". > I think for every type of parameters a simple checkbox is sufficient. > I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by JIRA noreply@jenkins-ci.org
[ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on JENKINS-8916 started by Fred G. > Allowing same type of parameter for triggered build more than once seems redundant > ---------------------------------------------------------------------------------- > > Key: JENKINS-8916 > URL: https://issues.jenkins-ci.org/browse/JENKINS-8916 > Project: Jenkins > Issue Type: Bug > Components: parameterized-trigger > Affects Versions: current > Reporter: Fred G > Assignee: Fred G > Priority: Minor > > While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. > For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. > The only type where it might make sense is "Parameters from properties file". > I think for every type of parameters a simple checkbox is sufficient. > I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by JIRA noreply@jenkins-ci.org
[ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred G reassigned JENKINS-8916: ------------------------------- Assignee: Fred G (was: huybrechts) > Allowing same type of parameter for triggered build more than once seems redundant > ---------------------------------------------------------------------------------- > > Key: JENKINS-8916 > URL: https://issues.jenkins-ci.org/browse/JENKINS-8916 > Project: Jenkins > Issue Type: Bug > Components: parameterized-trigger > Affects Versions: current > Reporter: Fred G > Assignee: Fred G > Priority: Minor > > While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. > For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. > The only type where it might make sense is "Parameters from properties file". > I think for every type of parameters a simple checkbox is sufficient. > I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by JIRA noreply@jenkins-ci.org
[ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162475#comment-162475 ] Fred G commented on JENKINS-8916: --------------------------------- Pull request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/20 > Allowing same type of parameter for triggered build more than once seems redundant > ---------------------------------------------------------------------------------- > > Key: JENKINS-8916 > URL: https://issues.jenkins-ci.org/browse/JENKINS-8916 > Project: Jenkins > Issue Type: Bug > Components: parameterized-trigger > Affects Versions: current > Reporter: Fred G > Assignee: Fred G > Priority: Minor > > While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. > For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. > The only type where it might make sense is "Parameters from properties file". > I think for every type of parameters a simple checkbox is sufficient. > I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by JIRA noreply@jenkins-ci.org
[ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162630#comment-162630 ] SCM/JIRA link daemon commented on JENKINS-8916: ----------------------------------------------- Code changed in jenkins User: Fred G Path: src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly http://jenkins-ci.org/commit/parameterized-trigger-plugin/3f6097a82679a76d8b0b03498d9c9a392b77f6fc Log: [FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant It requires Jenkins core version 1.463 to work, but it's fully backwards compatible. > Allowing same type of parameter for triggered build more than once seems redundant > ---------------------------------------------------------------------------------- > > Key: JENKINS-8916 > URL: https://issues.jenkins-ci.org/browse/JENKINS-8916 > Project: Jenkins > Issue Type: Bug > Components: parameterized-trigger > Affects Versions: current > Reporter: Fred G > Assignee: Fred G > Priority: Minor > > While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. > For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. > The only type where it might make sense is "Parameters from properties file". > I think for every type of parameters a simple checkbox is sufficient. > I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by JIRA noreply@jenkins-ci.org
[ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] SCM/JIRA link daemon resolved JENKINS-8916. ------------------------------------------- Resolution: Fixed > Allowing same type of parameter for triggered build more than once seems redundant > ---------------------------------------------------------------------------------- > > Key: JENKINS-8916 > URL: https://issues.jenkins-ci.org/browse/JENKINS-8916 > Project: Jenkins > Issue Type: Bug > Components: parameterized-trigger > Affects Versions: current > Reporter: Fred G > Assignee: Fred G > Priority: Minor > > While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. > For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. > The only type where it might make sense is "Parameters from properties file". > I think for every type of parameters a simple checkbox is sufficient. > I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by JIRA noreply@jenkins-ci.org
[ https://issues.jenkins-ci.org/browse/JENKINS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162631#comment-162631 ] SCM/JIRA link daemon commented on JENKINS-8916: ----------------------------------------------- Code changed in jenkins User: Fred G Path: src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly http://jenkins-ci.org/commit/parameterized-trigger-plugin/6e80ae37591b708b321b27a80a8d32012949f6a0 Log: Merge pull request #20 from fredg02/master [FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/76d4c9b...6e80ae3 > Allowing same type of parameter for triggered build more than once seems redundant > ---------------------------------------------------------------------------------- > > Key: JENKINS-8916 > URL: https://issues.jenkins-ci.org/browse/JENKINS-8916 > Project: Jenkins > Issue Type: Bug > Components: parameterized-trigger > Affects Versions: current > Reporter: Fred G > Assignee: Fred G > Priority: Minor > > While working on [JENKINS-7377] I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once. > For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times. > The only type where it might make sense is "Parameters from properties file". > I think for every type of parameters a simple checkbox is sufficient. > I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by JIRA noreply@jenkins-ci.org
|
|||||||||||
|
In reply to this post by JIRA noreply@jenkins-ci.org
|
|||||||||||
|
In reply to this post by JIRA noreply@jenkins-ci.org
|
|
In reply to this post by JIRA noreply@jenkins-ci.org
|
|||||||||||
|
In reply to this post by JIRA noreply@jenkins-ci.org
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
|||||||||||
|
In reply to this post by JIRA noreply@jenkins-ci.org
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]. For more options, visit https://groups.google.com/groups/opt_out. |
|||||||||||
| Powered by Nabble | Edit this page |

All parameter sources are only supported once now, i.e. it's not possible to specify multiple property files anymore?