[JIRA] Created: (JENKINS-11105) Pipeline view's retry is broken on parametized jobs since it doesn't reuse the arguments

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] Created: (JENKINS-11105) Pipeline view's retry is broken on parametized jobs since it doesn't reuse the arguments

JIRA noreply@jenkins-ci.org
Pipeline view's retry is broken on parametized jobs since it doesn't reuse the arguments
----------------------------------------------------------------------------------------

                 Key: JENKINS-11105
                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11105
             Project: Jenkins
          Issue Type: Bug
          Components: plugin
            Reporter: Devin Barbieri


The retry button in the Pipeline view should reuse the arguments of that specific job run, instead it uses default values.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-11105) Pipeline view's retry is broken on parametized jobs since it doesn't reuse the arguments

JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159369#comment-159369 ]

duality72 commented on JENKINS-11105:
-------------------------------------

I made some changes to the code to accomplish this for my cloned copy of this plugin.

http://code.google.com/r/duality72-expweb/source/detail?r=91cf341f53d211bd5499f822136a8c857141927d

For some reason, the plugin currently retrieves the parameters from the upstream build that is causing the current project to be built and adds those parameters when retrying the build. That didn't make sense to us, so we replaced copying the upstream build parameters with copying the build parameters from the build that is being retried. If for some reason the upstream build parameters are important, it would be easy to merge those in by modifying BuildUtil.getAllBuildParametersAction(). Other changes accommodate all this by passing the current build number into the retry method, look up the current build and its parameters, etc.

Unfortunately, my cloned copy is from July 2011 (and includes other changes for retrieving Perforce revisions), so I don't know how easy this code could be pulled into the mainline, but the idea is pretty straight-forward and should be easy enough to do again for those so inclined.
               

> Pipeline view's retry is broken on parametized jobs since it doesn't reuse the arguments
> ----------------------------------------------------------------------------------------
>
>                 Key: JENKINS-11105
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11105
>             Project: Jenkins
>          Issue Type: Bug
>          Components: plugin
>            Reporter: Devin Barbieri
>
> The retry button in the Pipeline view should reuse the arguments of that specific job run, instead it uses default values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[JIRA] (JENKINS-11105) Pipeline view's retry is broken on parametized jobs since it doesn't reuse the arguments

JIRA noreply@jenkins-ci.org
In reply to this post by JIRA noreply@jenkins-ci.org

    [ https://issues.jenkins-ci.org/browse/JENKINS-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159400#comment-159400 ]

Devin Barbieri commented on JENKINS-11105:
------------------------------------------

There is a thread going on about this here: http://code.google.com/p/build-pipeline-plugin/issues/detail?can=2&start=0&num=100&q=&colspec=ID%20Type%20Status%20Priority%20Milestone%20Owner%20Summary&groupby=&sort=&id=75

I posted that you had a fix for this
               

> Pipeline view's retry is broken on parametized jobs since it doesn't reuse the arguments
> ----------------------------------------------------------------------------------------
>
>                 Key: JENKINS-11105
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-11105
>             Project: Jenkins
>          Issue Type: Bug
>          Components: plugin
>            Reporter: Devin Barbieri
>
> The retry button in the Pipeline view should reuse the arguments of that specific job run, instead it uses default values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Loading...