Buildhive not doing a clean?

[cjo9900]

Hi all,

I have been correcting a few issues in the parameterized-trigger-plugin, and in one of these pull request I add a reference to the Envinject lib plugin.

when the build hive builds this there are no issues, 

https://buildhive.cloudbees.com/job/jenkinsci/job/parameterized-trigger-plugin/15/

However builds after this that do not have this reference in the pom fail, due to the class being left in the target directory.

https://buildhive.cloudbees.com/job/jenkinsci/job/parameterized-trigger-plugin/16/

Errors are: 

[ERROR] Undefined reference: org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever in /scratch/hudson/workspace/jenkinsci/parameterized-trigger-plugin/target/classes/hudson/plugins/parameterizedtrigger/EnvInjectParameters.class

[ERROR] Undefined reference: org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.<init>()V in /scratch/hudson/workspace/jenkinsci/parameterized-trigger-plugin/target/classes/hudson/plugins/parameterizedtrigger/EnvInjectParameters.class

[ERROR] Undefined reference: org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.getEnvInjectAction(Lhudson/model/AbstractBuild;)Lhudson/model/Action; in /scratch/hudson/workspace/jenkinsci/parameterized-trigger-plugin/target/classes/hudson/plugins/parameterizedtrigger/EnvInjectParameters.class

Same occured beweeen builds 13 and 14 where build 14 was a commit to the master.

https://buildhive.cloudbees.com/job/jenkinsci/job/parameterized-trigger-plugin/13/

https://buildhive.cloudbees.com/job/jenkinsci/job/parameterized-trigger-plugin/14/

From the log it does not look as if the clean stage is called at all, which in the case of building different pull requests I think should occur as each pull request should be merged with master only, not with other pull requests.

As the Buildhive is connected to github to provide feedback on pull requests, having these failures causes a lot of false results and comments added to pull/commits suggesting that things are broken when they are not.

Can someone have a look and set the correct maven goals.

Thanks

Chris

[Jesse Glick-4]

On 07/30/2012 01:24 PM, cjo wrote:
> Can someone have a look and set the correct maven goals.

The admin for a BH job can override the default goal list ('install') to include 'clean'. But better (I think) is to do the clean as part of the Git update step, as it is
more foolproof and potentially more efficient. I have started the process of updating BH Maven jobs to use the "Clean workspace" option of the Git plugin, and
https://buildhive.cloudbees.com/job/jenkinsci/job/parameterized-trigger-plugin/18/ seems to have done better with that.

[cjo9900]

Thanks, 

On Monday, July 30, 2012 7:23:09 PM UTC+1, Jesse Glick wrote:

On 07/30/2012 01:24 PM, cjo wrote:
> Can someone have a look and set the correct maven goals.

The admin for a BH job can override the default goal list ('install') to include 'clean'. But better (I think) is to do the clean as part of the Git update step, as it is
more foolproof and potentially more efficient. I have started the process of updating BH Maven jobs to use the "Clean workspace" option of the Git plugin, and
https://buildhive.cloudbees.com/job/jenkinsci/job/parameterized-trigger-plugin/18/ seems to have done better with that.

[Jesse Glick-4]

FYI, there is some other problem with this job now, possibly having to do with prevalidated merge commits not getting correctly loaded after a Jenkins restart. It may
clear up on its own when new commits are pushed to GitHub; if not, ping me.