Backports to LTS 1.480.1

[Vojtech Juranek]

Hi,
as agreed on the last Jenkins meeting [1], next LTS will be based on 1.480.
I identified and backported following bug fixes:

JENKINS-13336 Invalid JSON is produced during remote api operations [2]
JENKINS-14667 java.io.InvalidClassException [3]
JENKINS-15277 Check view permissions before showing config page [4]
JENKINS-15493 Excessive memory usage with large number of request threads [5]

Please let me know by Tuesday if there are any other critical or blocker
issues need to be backported to 1.480.1. As also agree on the meeting, RC
should be available by Wednesday.

Thanks
Vojta

[1] http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
[2] https://issues.jenkins-ci.org/browse/JENKINS-13336
[3] https://issues.jenkins-ci.org/browse/JENKINS-14667       
[4] https://issues.jenkins-ci.org/browse/JENKINS-15277
[5] https://issues.jenkins-ci.org/browse/JENKINS-15493

[nicolas de loof-2]

Makes me wonder : can we have some way on Jira to tag issues as "request backport to LTS", so that LTS management would not require you to do such a reminder ?

2012/10/21 Vojtech Juranek <[hidden email]>

Hi,
as agreed on the last Jenkins meeting [1], next LTS will be based on 1.480.
I identified and backported following bug fixes:

JENKINS-13336 Invalid JSON is produced during remote api operations [2]
JENKINS-14667 java.io.InvalidClassException [3]
JENKINS-15277 Check view permissions before showing config page [4]
JENKINS-15493 Excessive memory usage with large number of request threads [5]

Please let me know by Tuesday if there are any other critical or blocker
issues need to be backported to 1.480.1. As also agree on the meeting, RC
should be available by Wednesday.

Thanks
Vojta

[1] http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
[2] https://issues.jenkins-ci.org/browse/JENKINS-13336
[3] https://issues.jenkins-ci.org/browse/JENKINS-14667
[4] https://issues.jenkins-ci.org/browse/JENKINS-15277
[5] https://issues.jenkins-ci.org/browse/JENKINS-15493

[Vojtech Juranek]

I guess this marker is that the issue is either "blocker" or "critical" (+ the
fix has to be in Jenkins for at least cca 2 weeks).

I'm asking because someone could forget to bump the issue to critical (default
is "major") or I can miss something (both happened in the past).


On Monday 22 October 2012 07:55:18 nicolas de loof wrote:

> Makes me wonder : can we have some way on Jira to tag issues as "*request
> backport to LTS*", so that LTS management would not require you to do such
> a reminder ?
>
> 2012/10/21 Vojtech Juranek <[hidden email]>
>
> > Hi,
> > as agreed on the last Jenkins meeting [1], next LTS will be based on
> > 1.480.
> > I identified and backported following bug fixes:
> >
> > JENKINS-13336 Invalid JSON is produced during remote api operations [2]
> > JENKINS-14667 java.io.InvalidClassException [3]
> > JENKINS-15277 Check view permissions before showing config page [4]
> > JENKINS-15493 Excessive memory usage with large number of request threads
> > [5]
> >
> > Please let me know by Tuesday if there are any other critical or blocker
> > issues need to be backported to 1.480.1. As also agree on the meeting, RC
> > should be available by Wednesday.
> >
> > Thanks
> > Vojta
> >
> > [1]
> > http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
> > [2] https://issues.jenkins-ci.org/browse/JENKINS-13336
> > [3] https://issues.jenkins-ci.org/browse/JENKINS-14667
> > [4] https://issues.jenkins-ci.org/browse/JENKINS-15277
> > [5] https://issues.jenkins-ci.org/browse/JENKINS-15493

[Nord, James]

I would like to nominate JENKINS-15382 [1]

Not a critical or blocker, but it caused me some intermittent grief. (and I've been running this in production backported to 1.466.2 thanks to Cloudbees)

/James

[1] https://issues.jenkins-ci.org/browse/JENKINS-15382.

> -----Original Message-----
> From: [hidden email] [mailto:jenkinsci-
> [hidden email]] On Behalf Of Vojtech Juranek
> Sent: 21 October 2012 21:55
> To: [hidden email]
> Subject: Backports to LTS 1.480.1
>
> Hi,
> as agreed on the last Jenkins meeting [1], next LTS will be based on 1.480.
> I identified and backported following bug fixes:
>
> JENKINS-13336 Invalid JSON is produced during remote api operations [2]
> JENKINS-14667 java.io.InvalidClassException [3]
> JENKINS-15277 Check view permissions before showing config page [4]
> JENKINS-15493 Excessive memory usage with large number of request threads
> [5]
>
> Please let me know by Tuesday if there are any other critical or blocker issues
> need to be backported to 1.480.1. As also agree on the meeting, RC should be
> available by Wednesday.
>
> Thanks
> Vojta
>
> [1] http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
> [2] https://issues.jenkins-ci.org/browse/JENKINS-13336
> [3] https://issues.jenkins-ci.org/browse/JENKINS-14667
> [4] https://issues.jenkins-ci.org/browse/JENKINS-15277
> [5] https://issues.jenkins-ci.org/browse/JENKINS-15493

________________________________


**************************************************************************************
This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the [hidden email] and delete it from your system as well as any copies. The content of e-mails as well as traffic data may be monitored by NDS for employment and security purposes. To protect the environment please do not print this e-mail unless necessary.

NDS Limited. Registered Office: One London Road, Staines, Middlesex, TW18 4EX, United Kingdom. A company registered in England and Wales. Registered no. 3080780. VAT no. GB 603 8808 40-00
**************************************************************************************

[Vojtech Juranek]

Done

On Monday 22 October 2012 09:19:45 Nord, James wrote:

> I would like to nominate JENKINS-15382 [1]
>
> Not a critical or blocker, but it caused me some intermittent grief. (and
> I've been running this in production backported to 1.466.2 thanks to
> Cloudbees)
>
> /James
>
> [1] https://issues.jenkins-ci.org/browse/JENKINS-15382.
>
> > -----Original Message-----
> > From: [hidden email] [mailto:jenkinsci-
> > [hidden email]] On Behalf Of Vojtech Juranek
> > Sent: 21 October 2012 21:55
> > To: [hidden email]
> > Subject: Backports to LTS 1.480.1
> >
> > Hi,
> > as agreed on the last Jenkins meeting [1], next LTS will be based on
> > 1.480.
> > I identified and backported following bug fixes:
> >
> > JENKINS-13336 Invalid JSON is produced during remote api operations [2]
> > JENKINS-14667 java.io.InvalidClassException [3]
> > JENKINS-15277 Check view permissions before showing config page [4]
> > JENKINS-15493 Excessive memory usage with large number of request threads
> > [5]
> >
> > Please let me know by Tuesday if there are any other critical or blocker
> > issues need to be backported to 1.480.1. As also agree on the meeting, RC
> > should be available by Wednesday.
> >
> > Thanks
> > Vojta
> >
> > [1]
> > http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
> > [2] https://issues.jenkins-ci.org/browse/JENKINS-13336
> > [3] https://issues.jenkins-ci.org/browse/JENKINS-14667
> > [4] https://issues.jenkins-ci.org/browse/JENKINS-15277
> > [5] https://issues.jenkins-ci.org/browse/JENKINS-15493
>
> ________________________________
>
>
> ****************************************************************************
> ********** This message is confidential and intended only for the addressee.
> If you have received this message in error, please immediately notify the
> [hidden email] and delete it from your system as well as any copies.
> The content of e-mails as well as traffic data may be monitored by NDS for
> employment and security purposes. To protect the environment please do not
> print this e-mail unless necessary.
>
> NDS Limited. Registered Office: One London Road, Staines, Middlesex, TW18
> 4EX, United Kingdom. A company registered in England and Wales. Registered
> no. 3080780. VAT no. GB 603 8808 40-00
> ***************************************************************************
> ***********

[Kohsuke Kawaguchi]

I'm flying back to home today, and planning to take a sweep Tuesday afternoon.

2012/10/22 Vojtech Juranek <[hidden email]>:

> Hi,
> as agreed on the last Jenkins meeting [1], next LTS will be based on 1.480.
> I identified and backported following bug fixes:
>
> JENKINS-13336 Invalid JSON is produced during remote api operations [2]
> JENKINS-14667 java.io.InvalidClassException [3]
> JENKINS-15277 Check view permissions before showing config page [4]
> JENKINS-15493 Excessive memory usage with large number of request threads [5]
>
> Please let me know by Tuesday if there are any other critical or blocker
> issues need to be backported to 1.480.1. As also agree on the meeting, RC
> should be available by Wednesday.
>
> Thanks
> Vojta
>
> [1] http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
> [2] https://issues.jenkins-ci.org/browse/JENKINS-13336
> [3] https://issues.jenkins-ci.org/browse/JENKINS-14667
> [4] https://issues.jenkins-ci.org/browse/JENKINS-15277
> [5] https://issues.jenkins-ci.org/browse/JENKINS-15493

--
Kohsuke Kawaguchi

[Jesse Glick-4]

On 10/21/2012 04:54 PM, Vojtech Juranek wrote:
> any other critical or blocker issues need to be backported to 1.480.1

JENKINS-7214 [1] should be considered; large installations can be slowed to a crawl by this longstanding issue. Ditto JENKINS-15206 [2]. Neither are trivial fixes, though.

JENKINS-15226 [3] is not exactly a severe bug but it makes reviewing logs (critical for debugging certain plugins) very difficult when running on JDK 7 and the fix is simple.

JENKINS-15494 [4] is too new I guess, by a couple of days.


[1] https://issues.jenkins-ci.org/browse/JENKINS-7214
[2] https://issues.jenkins-ci.org/browse/JENKINS-15206
[3] https://issues.jenkins-ci.org/browse/JENKINS-15226
[4] https://issues.jenkins-ci.org/browse/JENKINS-15494

[Vojtech Juranek]

> JENKINS-15494 [4] is too new I guess, by a couple of days.
>
>
> [1] https://issues.jenkins-ci.org/browse/JENKINS-7214
> [2] https://issues.jenkins-ci.org/browse/JENKINS-15206
> [3] https://issues.jenkins-ci.org/browse/JENKINS-15226
> [4] https://issues.jenkins-ci.org/browse/JENKINS-15494

[1,2,3] backported, and yes, [4] is too new

[Jesse Glick-4]

On 10/23/2012 03:33 PM, Vojtech Juranek wrote:
> https://issues.jenkins-ci.org/browse/JENKINS-15206

You merged the main commit but not the follow-up 06514d2.

[Vojtech Juranek]

On Tuesday 23 October 2012 15:40:16 Jesse Glick wrote:
> On 10/23/2012 03:33 PM, Vojtech Juranek wrote:
> > https://issues.jenkins-ci.org/browse/JENKINS-15206
>
> You merged the main commit but not the follow-up 06514d2.

it's already there (got a notification from failing test
hudson.model.ViewTest.testAllImagesCanBeLoaded)

[Vojtech Juranek]

FYI: on JonJ there are some failed tests because of time out [1], on our
instance it passed without any failure [2], so there shouldn't be any
regressions caused by backporting

[1] https://ci.jenkins-ci.org/view/Jenkins%20core/job/jenkins_lts_branch/75/
[2] http://ci.jboss.org/hudson/job/HTS-Jenkins-LTS/31/

On Tuesday 23 October 2012 12:10:02 Kohsuke Kawaguchi wrote:

> I'm flying back to home today, and planning to take a sweep Tuesday
> afternoon.
> 2012/10/22 Vojtech Juranek <[hidden email]>:
> > Hi,
> > as agreed on the last Jenkins meeting [1], next LTS will be based on
> > 1.480.
> > I identified and backported following bug fixes:
> >
> > JENKINS-13336 Invalid JSON is produced during remote api operations [2]
> > JENKINS-14667 java.io.InvalidClassException [3]
> > JENKINS-15277 Check view permissions before showing config page [4]
> > JENKINS-15493 Excessive memory usage with large number of request threads
> > [5]
> >
> > Please let me know by Tuesday if there are any other critical or blocker
> > issues need to be backported to 1.480.1. As also agree on the meeting, RC
> > should be available by Wednesday.
> >
> > Thanks
> > Vojta
> >
> > [1]
> > http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
> > [2] https://issues.jenkins-ci.org/browse/JENKINS-13336
> > [3] https://issues.jenkins-ci.org/browse/JENKINS-14667
> > [4] https://issues.jenkins-ci.org/browse/JENKINS-15277
> > [5] https://issues.jenkins-ci.org/browse/JENKINS-15493

[Kohsuke Kawaguchi]

RC posted.

2012/10/24 Vojtech Juranek <[hidden email]>:

> FYI: on JonJ there are some failed tests because of time out [1], on our
> instance it passed without any failure [2], so there shouldn't be any
> regressions caused by backporting
>
> [1] https://ci.jenkins-ci.org/view/Jenkins%20core/job/jenkins_lts_branch/75/
> [2] http://ci.jboss.org/hudson/job/HTS-Jenkins-LTS/31/
>
> On Tuesday 23 October 2012 12:10:02 Kohsuke Kawaguchi wrote:
>> I'm flying back to home today, and planning to take a sweep Tuesday
>> afternoon.
>> 2012/10/22 Vojtech Juranek <[hidden email]>:
>> > Hi,
>> > as agreed on the last Jenkins meeting [1], next LTS will be based on
>> > 1.480.
>> > I identified and backported following bug fixes:
>> >
>> > JENKINS-13336 Invalid JSON is produced during remote api operations [2]
>> > JENKINS-14667 java.io.InvalidClassException [3]
>> > JENKINS-15277 Check view permissions before showing config page [4]
>> > JENKINS-15493 Excessive memory usage with large number of request threads
>> > [5]
>> >
>> > Please let me know by Tuesday if there are any other critical or blocker
>> > issues need to be backported to 1.480.1. As also agree on the meeting, RC
>> > should be available by Wednesday.
>> >
>> > Thanks
>> > Vojta
>> >
>> > [1]
>> > http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
>> > [2] https://issues.jenkins-ci.org/browse/JENKINS-13336
>> > [3] https://issues.jenkins-ci.org/browse/JENKINS-14667
>> > [4] https://issues.jenkins-ci.org/browse/JENKINS-15277
>> > [5] https://issues.jenkins-ci.org/browse/JENKINS-15493

--
Kohsuke Kawaguchi

[nicolas de loof-2]

2012/10/25 Vojtech Juranek <[hidden email]>

FYI: on JonJ there are some failed tests because of time out [1], on our
instance it passed without any failure [2], so there shouldn't be any
regressions caused by backporting

[1] https://ci.jenkins-ci.org/view/Jenkins%20core/job/jenkins_lts_branch/75/
[2] http://ci.jboss.org/hudson/job/HTS-Jenkins-LTS/31/

https://jenkins.ci.cloudbees.com/job/core/job/jenkins_lts_branch/23/ also has some tests to fail on TO, even with -Dmaven.junit.timeout=600 , so I wonder there is some unpredictability here 

 

On Tuesday 23 October 2012 12:10:02 Kohsuke Kawaguchi wrote:
> I'm flying back to home today, and planning to take a sweep Tuesday
> afternoon.
> 2012/10/22 Vojtech Juranek <[hidden email]>:
> > Hi,
> > as agreed on the last Jenkins meeting [1], next LTS will be based on
> > 1.480.
> > I identified and backported following bug fixes:
> >
> > JENKINS-13336 Invalid JSON is produced during remote api operations [2]
> > JENKINS-14667 java.io.InvalidClassException [3]
> > JENKINS-15277 Check view permissions before showing config page [4]
> > JENKINS-15493 Excessive memory usage with large number of request threads
> > [5]
> >
> > Please let me know by Tuesday if there are any other critical or blocker
> > issues need to be backported to 1.480.1. As also agree on the meeting, RC
> > should be available by Wednesday.
> >
> > Thanks
> > Vojta
> >
> > [1]
> > http://meetings.jenkins-ci.org/jenkins/2012/jenkins.2012-10-17-18.02.html
> > [2] https://issues.jenkins-ci.org/browse/JENKINS-13336
> > [3] https://issues.jenkins-ci.org/browse/JENKINS-14667
> > [4] https://issues.jenkins-ci.org/browse/JENKINS-15277
> > [5] https://issues.jenkins-ci.org/browse/JENKINS-15493

[Jesse Glick-4]

I forgot to bring up JENKINS-13202 [1], relating to problems archiving due to advanced filesystem operations (esp. symlinks) on relatively unusual operating systems,
which is a little complicated:

1. 95c1728 made an improvement, but this was already in 1.467 (and an even earlier e15b2e1 in 1.465).

2. In 1.482 I did f50316b [2] as a hotfix.

3. Shortly thereafter in 1.483 I also did 646154f (followed up by ced5c44) which used Java 7 to provide real support on those systems, a riskier fix probably not suitable
for backporting.

4. In the closely related JENKINS-13614 [3] nickolay_martinov also proposed a patch [4] (applied to DirScanner.Glob but easily copied to DirScanner.Full) which would have
a similar effect as #2.

Severity: high—effectively prevents usage of certain operating systems as slaves. Suggestion: backport f50316b which is pretty small and should be safe; Nickolay’s patch
(if extended as mentioned above) would be about as good for a backport but has not been tested in trunk. I hope it is not too late for 1.480.1; if so, keep it in mind for
1.480.2.

There are reports of other slave archiving problems but without a clear diagnosis of the problem and I suspect they are unrelated bugs.


[1] https://issues.jenkins-ci.org/browse/JENKINS-13202
[2] https://github.com/jenkinsci/jenkins/commit/f50316b66a8e4761193c46f824fbd620ffccd6c0
[3] https://issues.jenkins-ci.org/browse/JENKINS-13614
[4] https://issues.jenkins-ci.org/secure/attachment/21806/JENKINS-13614.patch

[Vojtech Juranek]

Hi,

> Suggestion: backport f50316b which is pretty small and should be
> safe;

done

> Nickolay’s patch (if extended as mentioned above) would be about as
> good for a backport but has not been tested in trunk.

as this is not even in trunk yet, I don't include this patch

> I hope it is not too
> late for 1.480.1; if so, keep it in mind for 1.480.2.

will try to keep in mind and include other possible fixes in 1.480.2

@Kohsuke would you mind re-spin RC to include this fix? It passed all tests
[1].

Thanks
Vojta


[1] https://hudson.jboss.org/hudson/job/HTS-Jenkins-LTS/32 (will be published
in a few hours, out build publisher lags today ;-()

[Vojtech Juranek]

> @Kohsuke would you mind re-spin RC to include this fix? It passed all tests
> [1].

or, taken into account that backported fix/workaround is just wrapping one line
into try-catch block, new RC is probably not needed at all. I'll start testing
today with original RC

[Vojtech Juranek]

On Wednesday 24 October 2012 21:01:24 Kohsuke Kawaguchi wrote:
> RC posted.

unfortunately it's not propagated to the mirrors and cannot be downloaded.
Could you (or someone with admin access - rtyler?) take a look and put it to
the mirrors?

Thanks
Vojta

[Edward Cullen]

On 21/10/12 21:54, Vojtech Juranek wrote:
> Hi,
> as agreed on the last Jenkins meeting [1], next LTS will be based on 1.480.
> I identified and backported following bug fixes:

We've just hit this in our production environment:

JENKINS-15369 - NPE from Jenkins.removeNode [1]

Eddy

[1] https://issues.jenkins-ci.org/browse/JENKINS-15369

--
Edward Cullen
Software Engineer
n.able Technology Services
mailto:[hidden email]

Assigned to HP StorageWorks VDU (D2D)
-----------------------------------------------------------------------
Hewlett-Packard, Long Down Avenue, Stoke Gifford, Bristol, BS34 8QZ,
United Kingdom.

The contents of this message and any attachments to it are confidential
and may be legally privileged. If you have received this message in
error you should delete it from your system immediately and advise the
sender.
To any recipient of this message within HP, unless otherwise stated, you
should consider this message and attachments as 'HP CONFIDENTIAL'.

[Jesse Glick-4]

On 10/30/2012 05:48 AM, Edward Cullen wrote:
> We've just hit this in our production environment:
>
> JENKINS-15369 - NPE from Jenkins.removeNode

Do you have any idea how to reproduce? If so, do 300bfc4 & 87d9a6e help?

CloudBees encountered this NPE in our hosted Jenkins instances, we are guessing due to a bug in a hudson.slaves.Cloud plugin. I did not propose the fix for backporting
since the impact is not critical, the bug was not known to occur in other environments, and there is no verification of the fix.

[Kohsuke Kawaguchi]

Grr, my bad.

The new mainline release on Sunday flushed the queue and pushed
everything to the site properly.

2012/10/27 Vojtech Juranek <[hidden email]>:

> On Wednesday 24 October 2012 21:01:24 Kohsuke Kawaguchi wrote:
>> RC posted.
>
> unfortunately it's not propagated to the mirrors and cannot be downloaded.
> Could you (or someone with admin access - rtyler?) take a look and put it to
> the mirrors?
>
> Thanks
> Vojta
>
>

--
Kohsuke Kawaguchi